Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Refactor transitions/transforms #126

Closed
kkaefer opened this issue Apr 4, 2014 · 0 comments
Closed

Refactor transitions/transforms #126

kkaefer opened this issue Apr 4, 2014 · 0 comments
Assignees
Labels
performance Speed, stability, CPU usage, memory usage, or power usage

Comments

@kkaefer
Copy link
Member

kkaefer commented Apr 4, 2014

We should be more explicit about finding situations where we need a rerender vs. situations where the animation values didn't change. This is especially true for the timeout transition, which only changes a value after a certain time, but does not change the value inbetween. In those cases, we should be smart about not needing to iterate through the event loop and only wake up the event loop once the timeout is up.

@jfirebaugh jfirebaugh self-assigned this Apr 2, 2015
jfirebaugh added a commit that referenced this issue Apr 2, 2015
This brings the easing transition code a bit closer to how easings work
in gl-js. Instead of having an array of individual transitions for scale,
rotate, and pan, there is a single transition function that does all the
required calculations. This permits us to:

* Eliminate the "timeout" transition. (Fixes #126)
* Remove the start/stopPanning() and similar functions from the API. The
  transform is capable of determining when a transition that affects the
  pan position is in effect. (Fixes #79)
* Run style recalculations only when an ease transition that affects the
  zoom is in progress. (Fixes #1155)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
performance Speed, stability, CPU usage, memory usage, or power usage
Projects
None yet
Development

No branches or pull requests

3 participants