Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

refactor MGLMapViewDelegate into its own header #1385

Closed
incanus opened this issue Apr 30, 2015 · 4 comments
Closed

refactor MGLMapViewDelegate into its own header #1385

incanus opened this issue Apr 30, 2015 · 4 comments
Assignees
@incanus
Labels
iOS Mapbox Maps SDK for iOS refactor

Comments

@incanus
Copy link
Contributor

incanus commented Apr 30, 2015

We should move this out of MGLMapView.h to cut down on size, much like MapKit and our raster SDK.
@incanus incanus added iOS Mapbox Maps SDK for iOS refactor labels Apr 30, 2015
@incanus incanus added this to the iOS Beta 2 milestone Apr 30, 2015
1ec5 added a commit that referenced this issue May 21, 2015
@1ec5
Split MGLMapViewDelegate into separate header
2ec4f6e 
Fixes #1385.
@1ec5 1ec5 mentioned this issue May 21, 2015
Closed
@1ec5 1ec5 self-assigned this May 21, 2015
@1ec5 1ec5 removed their assignment May 26, 2015
@incanus
Copy link
Contributor Author

incanus commented Jun 1, 2015

Blocked by some work in #1655, but should be able to hit this pretty easily afterwards.

@incanus incanus self-assigned this Jun 1, 2015
@incanus
Copy link
Contributor Author

incanus commented Jun 15, 2015

Still planning on getting this when #1655 lands, as it's mostly a cut-and-paste job.

@incanus incanus modified the milestones: iOS Beta 2, iOS Beta 3 Jun 17, 2015
@1ec5
Copy link
Contributor

1ec5 commented Jun 25, 2015

While you’re at it, would you mind filling out some of the “TODO” comments? -mapView:regionDidChangeAnimated: for example is implemented but not documented. Also, Xcode’s Quick Help always shows the doc comment preceding the declaration, so a host of delegate callbacks currently show documentation for -mapView:rightCalloutAccessoryViewForAnnotation:, which is confusing.

@incanus incanus modified the milestone: iOS Beta 3 Jul 7, 2015
@friedbunny
Copy link
Contributor

This happened on OS X, but still should happen on iOS.

@1ec5 1ec5 mentioned this issue Jun 6, 2016
Merged
@1ec5 1ec5 closed this as completed in #5246 Jun 6, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@incanus incanus

Labels
iOS Mapbox Maps SDK for iOS refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleaned up MGLMapViewDelegate mapbox/mapbox-gl-native
4 participants
@incanus @jfirebaugh @friedbunny @1ec5