This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Cleaned up MGLMapViewDelegate #1620
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the formerly-undocumented delegate methods, they don't all work. Past convention has been to only document methods that work properly so that developers feel free to use them. We should ticket out the methods and categories of functionality that don't work as well as mark the methods as buggy/unreliable in the header if we're going to do this. Related: #1431 |
|
Ah, I read "TODO" as "to document" rather than "to implement". We shouldn't even declare methods we don't support yet. There are plenty of other APIs we'd love to have but it doesn't make sense to put them in developers' autocomplete prematurely. |
|
Take two in #1976. |
|
I still like moving these to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It’s now in a separate header, MGLMapViewDelegate.h, and there are no longer any “TODO” comments where documentation comments belong.
Fixes #1385.