Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

While panning, location indicator wiggles significantly more on android compared to iOS (Android). #1676

Closed
mb12 opened this issue Jun 2, 2015 · 11 comments
Assignees
Labels
Android Mapbox Maps SDK for Android bug

Comments

@mb12
Copy link

mb12 commented Jun 2, 2015

Filing this issue for tracking purposes.
While panning, location indicator wiggles a lot more on Android compared to iOS. Maybe whatever changes were done for the following needs to be migrated for Android as well.

#1439

@1ec5
Copy link
Contributor

1ec5 commented Jun 2, 2015

#1439 was duped to #1125, which is still open. #1582 will get us to parity with MapKit by using Core Animation. Does Android have anything similar?

@1ec5 1ec5 added the Android Mapbox Maps SDK for Android label Jun 2, 2015
@ljbade
Copy link
Contributor

ljbade commented Jun 4, 2015

@1ec5 there is currently no filtering of the compass data. It is updating the screen as frequently as we get sensor data. We need to implement some sort of rate limit or other data filtering.

@ljbade ljbade added the bug label Jun 4, 2015
@ljbade ljbade added this to the Android Beta milestone Jun 4, 2015
@1ec5
Copy link
Contributor

1ec5 commented Jun 4, 2015

Would it be necessary to throttle the user location updates if the user dot animated to each location instead of blitting there?

@ljbade
Copy link
Contributor

ljbade commented Jun 4, 2015

The compass and GPS locations are separate data sources. Android already limits location to once a second so we need to do something similar with the compass.

@ljbade
Copy link
Contributor

ljbade commented Aug 13, 2015

This is still a problem even after @bleege recent changes.

@incanus How did you speed up the map/location marker sync?

@erf erf mentioned this issue Aug 13, 2015
@erf
Copy link
Contributor

erf commented Aug 13, 2015

@ljbade i created a pull request now #2065 regarding compass filtering. but after i had added the filtering like in a previous pull request, i saw that the FAB does not toggle into Follow mode. I guess @bleege is in the middle of some refactoring here, but would be nice if the filtering could be included if you test that it is ok. Thanks.

@incanus
Copy link
Contributor

incanus commented Aug 19, 2015

We need to insert the routine which updates the user dot's location on screen between these two lines:

map.renderSync();
map.nudgeTransitions();

Per #1125, renderSync draws the current GL frame, then nudgeTransitions updates the Transform, which affects any subsequent geo/screen conversions. If the user dot placement happens not between those two, it is using a Transform for the placement conversion that is not in sync with the GL draw.

@ljbade
Copy link
Contributor

ljbade commented Aug 20, 2015

@incanus Aha! Thanks for that pointer! I'm going to figure this one out

@bleege
Copy link
Contributor

bleege commented Aug 31, 2015

Bumping to 0.2.0.

@ljbade Any progress on this?

@bleege bleege modified the milestones: android-v0.2.0, android-v0.1.0 Aug 31, 2015
@ljbade
Copy link
Contributor

ljbade commented Sep 1, 2015

@bleege not yet, will pick this up after 0.1.0

@incanus
Copy link
Contributor

incanus commented Sep 4, 2015

When we clean this up to be driven by frame updates (building on #2255), we should be sure to clean this stuff up:

I think the idea with updateMap() on Java side was related to triggering the UI to fetch updated GPS coordinates and update the location of the GPS marker dot (it made sense at the time to use same code for map pan/zoom updates).

@ljbade ljbade self-assigned this Sep 24, 2015
ljbade pushed a commit that referenced this issue Sep 24, 2015
Move expensive cache size calulation to initialisation
Fix setGestureInProgress bug
Renamed several functions to match current usage
Refactor map updates to reduce GPS marker lag
Fixes #1676
Fixes #2290
Fixes #2396
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
Move expensive cache size calulation to initialisation
Fix setGestureInProgress bug
Renamed several functions to match current usage
Refactor map updates to reduce GPS marker lag
Fixes mapbox#1676
Fixes mapbox#2290
Fixes mapbox#2396
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android bug
Projects
None yet
Development

No branches or pull requests

6 participants