-
Notifications
You must be signed in to change notification settings - Fork 1.3k
While panning, location indicator wiggles significantly more on android compared to iOS (Android). #1676
Comments
@1ec5 there is currently no filtering of the compass data. It is updating the screen as frequently as we get sensor data. We need to implement some sort of rate limit or other data filtering. |
Would it be necessary to throttle the user location updates if the user dot animated to each location instead of blitting there? |
The compass and GPS locations are separate data sources. Android already limits location to once a second so we need to do something similar with the compass. |
@ljbade i created a pull request now #2065 regarding compass filtering. but after i had added the filtering like in a previous pull request, i saw that the FAB does not toggle into Follow mode. I guess @bleege is in the middle of some refactoring here, but would be nice if the filtering could be included if you test that it is ok. Thanks. |
We need to insert the routine which updates the user dot's location on screen between these two lines: mapbox-gl-native/android/cpp/native_map_view.cpp Lines 710 to 711 in fa18f1a
Per #1125, |
@incanus Aha! Thanks for that pointer! I'm going to figure this one out |
Bumping to @ljbade Any progress on this? |
@bleege not yet, will pick this up after |
When we clean this up to be driven by frame updates (building on #2255), we should be sure to clean this stuff up:
|
Move expensive cache size calulation to initialisation Fix setGestureInProgress bug Renamed several functions to match current usage Refactor map updates to reduce GPS marker lag Fixes mapbox#1676 Fixes mapbox#2290 Fixes mapbox#2396
Filing this issue for tracking purposes.
While panning, location indicator wiggles a lot more on Android compared to iOS. Maybe whatever changes were done for the following needs to be migrated for Android as well.
#1439
The text was updated successfully, but these errors were encountered: