This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I’d like to make user tracking smoother by sticking the user dot in the center of the screen and moving the viewport instead of the user dot. Unfortunately, |
Another problem is that |
This was referenced Jun 23, 2015
Closed
This was referenced Jul 3, 2015
#2204 complicates things here too. |
Closed
This was referenced Oct 14, 2015
5 tasks
I split the user tracking case out into #3589. |
1ec5
force-pushed
the
1ec5-dot-jank-1041
branch
from
January 19, 2016 06:29
b16438e
to
3d148fe
Compare
I rebased this branch atop #3589. It looks pretty good, other than a brief misplacement of the callout after selecting a user dot that’s in motion. /cc @friedbunny @zugaldia |
1ec5
force-pushed
the
1ec5-dot-jank-1041
branch
from
January 20, 2016 08:42
3d148fe
to
0148a9a
Compare
1ec5
force-pushed
the
1ec5-dot-jank-1041
branch
from
January 20, 2016 19:46
0148a9a
to
4bd0ecc
Compare
1ec5
force-pushed
the
1ec5-dot-jank-1041
branch
from
April 18, 2016 05:08
4bd0ecc
to
74d98c9
Compare
Use UIView animation to explicitly animate the user dot between user location updates. There is a tricky special case, which is that the callout must point to the annotation view’s implicit frame but must quickly rendezvous with the explicit frame. Fixes #1041.
1ec5
force-pushed
the
1ec5-dot-jank-1041
branch
from
April 18, 2016 05:46
74d98c9
to
52abcb5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the user dot would blit across the screen, and
MGLMapView
would try to keep up but would tragically remain one step behind. With this PR, the user andMGLMapView
waltz happily together.Make the viewport track the user dot more smoothly(split out into Affix user dot on screen in user tracking mode #3589)Keep the user dot from drifting when panning the map view with gestures(more or less addressed by Disable implicit animation of user dot bounds #3683)Depends on #3589. Fixes #1041. Ref #1125.