Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

User dot callout view dismisses when user location changes slightly #2618

Closed
1ec5 opened this issue Oct 14, 2015 · 8 comments
Closed

User dot callout view dismisses when user location changes slightly #2618

1ec5 opened this issue Oct 14, 2015 · 8 comments
Labels
iOS Mapbox Maps SDK for iOS

Comments

@1ec5
Copy link
Contributor

1ec5 commented Oct 14, 2015

On iOS, the user dot's callout view is automatically dismissed whenever the user location changes. It should not be dismissed when the location change is small, because that's usually just the result of Core Location refining its location.

/cc @friedbunny

@1ec5 1ec5 added the iOS Mapbox Maps SDK for iOS label Oct 14, 2015
@1ec5
Copy link
Contributor Author

1ec5 commented Oct 14, 2015

Keeping the callout view open in this case does not expose any view syncing performance issues, because the user dot itself isn't animated (see #1582).

@friedbunny
Copy link
Contributor

Sounds good to me. We show the accuracy pulse (haloLayer) when location accuracy is <10 meters, but I'm thinking an additional screen distance threshold may be better for the callout — unless potentially jumping all the way across the screen doesn't look that bad.

@incanus
Copy link
Contributor

incanus commented Oct 15, 2015

We should just ensure that the dot isn't in fact moving perceptibly, since we can't yet reposition callouts (or other views) synced to the map yet (#1125).

@1ec5
Copy link
Contributor Author

1ec5 commented Oct 15, 2015

@incanus, I don't think that's a problem in this case: #2618 (comment).

@incanus
Copy link
Contributor

incanus commented Oct 15, 2015

Right, so I guess we use -[MGLMapView metersPerPixelAtLatitude:] combined with changes of < 1 pixel.

@friedbunny
Copy link
Contributor

Is this adequately addressed by your recent changes in #3589, @1ec5?

@1ec5
Copy link
Contributor Author

1ec5 commented Jan 21, 2016

No, not until #1582 lands.

@1ec5
Copy link
Contributor Author

1ec5 commented Jan 21, 2016

I stand corrected: even though the user dot and its callout don’t animate around yet outside of user tracking mode, the callout view does stay open. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

No branches or pull requests

3 participants