Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Annotation callout closes automatically when changing the viewport #3154

Closed
incanus opened this issue Nov 30, 2015 · 4 comments
Closed

Annotation callout closes automatically when changing the viewport #3154

incanus opened this issue Nov 30, 2015 · 4 comments
Labels
bug iOS Mapbox Maps SDK for iOS MapKit parity For feature parity with MapKit on iOS or macOS
Milestone

Comments

@incanus
Copy link
Contributor

incanus commented Nov 30, 2015

Android now does this.

Complicated by the fact that SMCalloutView doesn't support a move API, just a placement/initial layout. On raster we used to use this repeatedly during viewport changes to sync up, but it became non-performant as of last check.

Refs #1125 #2412

@incanus incanus added GL JS parity For feature parity with Mapbox GL JS iOS Mapbox Maps SDK for iOS performance Speed, stability, CPU usage, memory usage, or power usage labels Nov 30, 2015
@incanus incanus changed the title leave annotation callout open during pans & zooms leave iOS annotation callout open during pans & zooms Nov 30, 2015
@1ec5
Copy link
Contributor

1ec5 commented Nov 30, 2015

Also leave it open when the user location changes: #2618.

@silviokuehn
Copy link

I have the same problem. Auto-closing of the annotation callouts after the map was moved (by app or manually by user interaction) seems to be a bad user experience. Moreover when you have a click event (button) within the callout bubble and user did a little bit move the finger while clicking, the pop-up disappears and the click event was not triggered.

As a workaround we tried a re-select of last selected annotation after a map move but that does not work really good.

@1ec5 1ec5 added this to the ios-v3.3.0 milestone Mar 18, 2016
@friedbunny friedbunny modified the milestones: ios-v3.4.0, ios-v3.3.0 Jun 17, 2016
@1ec5 1ec5 changed the title leave iOS annotation callout open during pans & zooms Annotation callout closes automatically when changing the viewport Jul 8, 2016
@boundsj boundsj removed the performance Speed, stability, CPU usage, memory usage, or power usage label Aug 15, 2016
@1ec5 1ec5 added MapKit parity For feature parity with MapKit on iOS or macOS and removed GL JS parity For feature parity with Mapbox GL JS labels Aug 15, 2016
@friedbunny friedbunny modified the milestones: ios-future, ios-v3.4.0 Aug 19, 2016
@1ec5 1ec5 added the bug label Oct 7, 2016
@1ec5
Copy link
Contributor

1ec5 commented Oct 7, 2016

As demonstrated by #1582, all we need to do is set self.calloutViewForSelectedAnnotation.frame, potentially inside a UIView animation block, instead of closing the callout view as we do now.

@1ec5
Copy link
Contributor

1ec5 commented Dec 5, 2016

Fixed in #6676 on the v3.4.0 release branch.

@1ec5 1ec5 closed this as completed Dec 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug iOS Mapbox Maps SDK for iOS MapKit parity For feature parity with MapKit on iOS or macOS
Projects
None yet
Development

No branches or pull requests

5 participants