This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
make Resource a variant type #3374
Labels
Comments
jfirebaugh
added a commit
that referenced
this issue
Dec 23, 2015
It's going to be exposed in the public core API as part of #3374.
jfirebaugh
added a commit
that referenced
this issue
Jan 5, 2016
Resource is going away as part of #3374. The only place that Resource#kind was used was to bypass an attempt at compression for sprite images. But it's fine for that path to just do the compression and use it if it works -- even if not optimal, sprite images account for a relatively small portion of cache rows.
jfirebaugh
added a commit
that referenced
this issue
Jan 5, 2016
Resource is going away as part of #3374. The only place that Resource#kind was used was to bypass an attempt at compression for sprite images. But it's fine for that path to just do the compression and use it if it works -- even if not optimal, sprite images account for a relatively small portion of cache rows.
jfirebaugh
added a commit
that referenced
this issue
Jan 8, 2016
Resource is going away as part of #3374. The only place that Resource#kind was used was to bypass an attempt at compression for sprite images. But it's fine for that path to just do the compression and use it if it works -- even if not optimal, sprite images account for a relatively small portion of cache rows.
jfirebaugh
changed the title
replace Resource::Kind with FileSource methods for each kind of resource
make Resource a variant type
Feb 11, 2016
Retitled: we should do this with a variant, not with a ton of virtual methods. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This is necessary for offline: the
OfflineFileSource
needs access to actualz
/x
/y
tile coordinates. It shouldn't try to guess them from the URL because there's no way to do that with 100% reliability.The text was updated successfully, but these errors were encountered: