This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Remove dependence on Resource from FileCache #3431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resource is going away as part of #3374. The only place that Resource#kind was used was to bypass an attempt at compression for sprite images. But it's fine for that path to just do the compression and use it if it works -- even if not optimal, sprite images account for a relatively small portion of cache rows.
|
The idea of storing the kind was that we could discriminate in the cache based on type (e.g. not compress images when storing them in the cache). However, it's probably enough to do magic header detection for those specific use cases. |
| @@ -68,7 +68,7 @@ void SQLiteCache::Impl::createSchema() { | |||
| "CREATE TABLE IF NOT EXISTS `http_cache` (" | |||
| " `url` TEXT PRIMARY KEY NOT NULL," | |||
| " `status` INTEGER NOT NULL," // The response status (Successful or Error). | |||
| " `kind` INTEGER NOT NULL," // The kind of file. | |||
| " `kind` INTEGER NOT NULL," // The kind of file. (No longer used; column remains only for backward compatibility.) | |||
There was a problem hiding this comment.
You can probably remove this, as the cache will get recreated anyway after #3429. Don't forget to bump the cache schema version.
|
Given recent offline discussions I'm not sure this is necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resourceis going away as part of #3374.The only place that
Resource#kindwas used was to bypass an attempt at compression for sprite images. But it's fine for that path to just do the compression and use it if it works -- even if not optimal, sprite images account for a relatively small portion of cache rows.@kkaefer Does that sound ok? Also, is there a reason for
http_cache_kind_idx? It doesn't seem like it would be utilized by any of the existing queries.