Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Map content insets should offset compass, logo, attribution beyond layout guides #3697

Closed
RomainQuidet opened this issue Jan 26, 2016 · 3 comments
Closed

Map content insets should offset compass, logo, attribution beyond layout guides #3697

RomainQuidet opened this issue Jan 26, 2016 · 3 comments
Assignees
@frederoni
Labels
bug iOS Mapbox Maps SDK for iOS
Milestone
ios-v3.3.1

Comments

@RomainQuidet
Copy link
Contributor

With current version the map insets on iOS work (user center is moved correctly) but the compass view is not moved inside the insets.
Same with the mapbox logo.
Insets are mostly used because another view hides temporally a part of the map. Users still want to see its compass.
@1ec5 1ec5 added bug iOS Mapbox Maps SDK for iOS labels Jan 26, 2016
@1ec5 1ec5 added this to the ios-v3.2.0 milestone Jan 26, 2016
@1ec5
Copy link
Contributor

1ec5 commented Jan 26, 2016

Insets are mostly used because another view hides temporally a part of the map. Users still want to see its compass.

I agree – good idea. Currently, -[MGLMapView updateConstraints] only respects the top and bottom layout guides.

@RomainQuidet
Copy link
Contributor Author

Working on it

@RomainQuidet
Copy link
Contributor Author

PL #4219 done, a little bit more than compass only, I also added the logo + attribution as all needs to be displayed on manual insets.

@RomainQuidet RomainQuidet mentioned this issue Mar 31, 2016
Closed
@boundsj boundsj modified the milestones: ios-v3.4.0, ios-v3.3.0 Jun 29, 2016
@1ec5 1ec5 changed the title [iOS] map insets should move compass view Map content insets should offset compass, logo, attribution beyond layout guides Jul 8, 2016
@1ec5 1ec5 modified the milestones: ios-v3.3.1, ios-v3.4.0 Jul 8, 2016
@boundsj boundsj self-assigned this Jul 11, 2016
frederoni added a commit that referenced this issue Jul 13, 2016
@frederoni
[ios] fixes #3697 compass, logo and attribution now respects mapview'…
96b0c58 
…s content inset
@boundsj boundsj assigned frederoni and unassigned boundsj Jul 13, 2016
frederoni added a commit that referenced this issue Jul 18, 2016
@frederoni
[ios] fixes #3697 compass, logo and attribution now respects mapview'…
c8cf608 
…s content inset
frederoni added a commit that referenced this issue Jul 18, 2016
@frederoni
[ios] fixes #3697 compass, logo and attribution now respects insets (#…
ede1e71 
…5671)

* [ios] fixes #3697 compass, logo and attribution now respects mapview's content inset

* [ios] fixed a bug which added duplicated constraints instead of updating

* [ios] layout guides are already taken into account in contentInset
@u10int u10int mentioned this issue Oct 4, 2016
Closed
@boundsj boundsj mentioned this issue Sep 13, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@frederoni frederoni

Labels
bug iOS Mapbox Maps SDK for iOS
Projects
None yet
Milestone
ios-v3.3.1
Development

No branches or pull requests
4 participants
@boundsj @frederoni @1ec5 @RomainQuidet