[ios] fixes #3697 compass, logo and attribution now respects insets

[frederoni]

Compass, logo and attribution button new respects the map view's content inset.

👀 @1ec5 @friedbunny @boundsj

[1ec5]

When the contentInset property changes, the constraints need to be updated immediately.

[frederoni]

Note: automaticallyAdjustsScrollViewInsets must be set to NO on the VC for the contentInset to be persistent. If not, contentInset will be adjusted automatically and logo, attribution and compass will fallback to its original position next time -layoutSubviews is called. This is consistent with how UIScrollView works. @1ec5 👀

[1ec5]

-layoutSubviews calls -adjustContentInset, which calls -setContentInset: and -setContentInset:animated:, which calls -setNeedsUpdateConstraints. I’m not quite sure, but are there any cases where that’ll cause a feedback loop?

[frederoni]

Not that I can find. -setNeedsUpdateConstraints will make sure a future call to -updateConstraintsIfNeeded calls -updateConstraints = no loop. If -adjustContentInset would get triggered in a loop, the loop is interrupted either because the previous contentInset is equal to the new or in case you're setting your own contentInset, it would get interrupted before that because of automaticallyAdjustsScrollViewInsets=NO

[1ec5]

👍

[postmechanical]

Will this make the 3.3.0 release?

[1ec5]

@postmechanical, no, v3.3.0 has already been released. 😃 But it will be in v3.3.1.