Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios] Also pass animated property when deselecting annotation views #5677

Merged
merged 1 commit into from
Jul 14, 2016

Conversation

friedbunny
Copy link
Contributor

This is the view annotation deselection counterpart to #5646 selection (that I neglected to check). Going to put this on v3.3.1, as this is a minor fix and we can live without it in the short term.

/cc @1ec5 @boundsj @frederoni

@friedbunny friedbunny added bug iOS Mapbox Maps SDK for iOS ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold annotations Annotations on iOS and macOS or markers on Android labels Jul 13, 2016
@friedbunny friedbunny added this to the ios-v3.3.1 milestone Jul 13, 2016
@friedbunny friedbunny self-assigned this Jul 13, 2016
@friedbunny
Copy link
Contributor Author

friedbunny commented Jul 13, 2016

In case anyone needs a workaround, my suggestion is to just ignore the incoming animated property in your MGLAnnotationView subclass’ implementation of -setSelected:selected animated:.

friedbunny added a commit to mapbox/ios-sdk-examples that referenced this pull request Jul 13, 2016
@friedbunny friedbunny removed the ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold label Jul 14, 2016
@friedbunny friedbunny merged commit d303980 into release-ios-v3.3.0 Jul 14, 2016
@friedbunny friedbunny deleted the fb-forgot-the-deselect branch July 14, 2016 23:50
1ec5 added a commit that referenced this pull request Jul 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
annotations Annotations on iOS and macOS or markers on Android bug iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant