This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios, build] Stop packaging i386 simulator arch #10772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akitchen
approved these changes
Dec 21, 2017
Only builds and packages x86_64 architecture in our frameworks and dSYM. Removes support for 32-bit simulators, such as the iPhone 5 and iPad 2. This does not affect device support — 32-bit devices are still supported via the arm7 architecture.
friedbunny
force-pushed
the
fb-only-package-64-bit-sim
branch
from
19329ff to
8e69a35
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes support for 32-bit simulators (
i386), such as the iPhone 5 and iPad 2. This does not affect device support — 32-bit devices are still supported via thearmv7architecture.This reduces the packaged size of our framework and dSYM by ~25%. This change does not affect the size of apps that integrate our SDK, as simulator architectures aren’t included in shipping apps.
For now, this does not change any Xcode project or mason settings, which allows iosapp to still run in 32-bit simulators. If you need to test using an older form factor using the packaged framework, try using the iPhone 5s, iPad Air, or iPad Mini 2 simulators.
/cc @1ec5 @akitchen @fabian-guerra