This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios] Re-add i386 slice to framework; strip from dSYM #10781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabian-guerra
approved these changes
Dec 21, 2017
|
Yes, let's introduce the more breaking change in our upcoming major release. Thanks! |
akitchen
approved these changes
Dec 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially revert #10772, as removing i386 from the framework was deemed too breaking of a change for a semver minor release. This builds and adds i386 everywhere (as before), but later explicitly strips i386 from the dSYM to reduce its file size.
We’ll likely remove i386 entirely in the next semver major release of this SDK.
/cc @akitchen @fabian-guerra