Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Prevent render thread from waking up unneeded on still rendering #11405

Merged
merged 1 commit into from
Mar 14, 2018

Conversation

ivovandongen
Copy link
Contributor

No longer sends a update message to the render frontend when rendering in still mode only to shortcut it in the renderer. This prevents unneeded render passes in qt.

- No longer sends a update message to the render frontend when rendering in still mode only to shortcut it in the renderer. This prevents unneeded render passes in qt.
@ivovandongen ivovandongen added the Core The cross-platform C++ core, aka mbgl label Mar 7, 2018
@ivovandongen ivovandongen self-assigned this Mar 7, 2018
Copy link
Contributor

@tmpsantos tmpsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This helps, but we still wake up the render thread many times because we are processing events on it. The map renderer is a scheduler. :-/

@ivovandongen
Copy link
Contributor Author

This helps, but we still wake up the render thread many times because we are processing events on it. The map renderer is a scheduler. :-/

@tmpsantos Yes. If this is needed we might need to reconsider the decision to go with a 2 thread instead of a 3 thread model as initially proposed.

@ivovandongen ivovandongen merged commit d7bc36d into master Mar 14, 2018
@ivovandongen ivovandongen deleted the ivd-shortcut-static-rendering branch March 14, 2018 14:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants