This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios, macos] Avoid implicit capture of MBGLOfflineRegionObserver this pointer #11821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pointer MBGLOfflineRegionObserver is owned by the offline database thread, and might be destroyed by the time the dispatch_async completes. Instead of implicitly capturing this, capture a copy of the MBGLOfflinePack weak pointer.
1ec5
reviewed
May 2, 2018
| @@ -227,19 +227,22 @@ - (void)didReceiveMaximumAllowedMapboxTiles:(uint64_t)limit { | |||
| @end | |||
|
|
|||
| void MBGLOfflineRegionObserver::statusChanged(mbgl::OfflineRegionStatus status) { | |||
| __weak MBGLOfflinePack *_pack = pack; | |||
There was a problem hiding this comment.
The class is called MGLOfflinePack, so the build is failing currently. The convention is to name the weak variable weakPack to more clearly distinguish the two variables.
|
Seems like the changelog entry will be easiest to add in the cherry pick to |
1ec5
approved these changes
May 2, 2018
This was referenced May 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MBGLOfflineRegionObserveris owned by the offline database thread, and might be destroyed by the time thedispatch_asynccompletes. Instead of implicitly capturingthis, capture a copy of theMBGLOfflinePackweak pointer.Speculatively fixes #6092.