Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios, macos] Avoid implicit capture of MBGLOfflineRegionObserver this pointer #11821

Merged
merged 2 commits into from
May 2, 2018
Merged

[ios, macos] Avoid implicit capture of MBGLOfflineRegionObserver this pointer #11821

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
491c718
[ios, macos] Avoid implicit capture of MBGLOfflineRegionObserver this…
jfirebaugh May 2, 2018
86a96d1
Fixup
jfirebaugh May 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions platform/darwin/src/MGLOfflinePack.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,19 +227,22 @@ - (void)didReceiveMaximumAllowedMapboxTiles:(uint64_t)limit {
@end

void MBGLOfflineRegionObserver::statusChanged(mbgl::OfflineRegionStatus status) {
__weak MGLOfflinePack *weakPack = pack;
dispatch_async(dispatch_get_main_queue(), ^{
[pack offlineRegionStatusDidChange:status];
[weakPack offlineRegionStatusDidChange:status];
});
}

void MBGLOfflineRegionObserver::responseError(mbgl::Response::Error error) {
__weak MGLOfflinePack *weakPack = pack;
dispatch_async(dispatch_get_main_queue(), ^{
[pack didReceiveError:MGLErrorFromResponseError(error)];
[weakPack didReceiveError:MGLErrorFromResponseError(error)];
});
}

void MBGLOfflineRegionObserver::mapboxTileCountLimitExceeded(uint64_t limit) {
__weak MGLOfflinePack *weakPack = pack;
dispatch_async(dispatch_get_main_queue(), ^{
[pack didReceiveMaximumAllowedMapboxTiles:limit];
[weakPack didReceiveMaximumAllowedMapboxTiles:limit];
});
}