This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios] Update changelog for v4.1.0-beta.1 #12086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are a variety of core changes that weren’t (and should have been) changelog’d — see the |
fabian-guerra
force-pushed
the
fabian-ios-v4.1.0-beta.1
branch
2 times, most recently
from
75e9241
to
b42cfcd
Compare
|
For some reason the podspec bump got caught in CP this #12087 |
friedbunny
changed the title
friedbunny
reviewed
Jun 11, 2018
platform/ios/CHANGELOG.md
Outdated
| @@ -21,6 +23,9 @@ Mapbox welcomes participation and contributions from everyone. Please read [CONT | |||
| * Added custom `-hitTest:withEvent:` to `MGLSMCalloutView` to avoid registering taps in transparent areas of the standard annotation callout. ([#11939](https://github.com/mapbox/mapbox-gl-native/pull/11939)) | |||
| * Improved performance and memory impact of `MGLScaleBar`. ([#11921](https://github.com/mapbox/mapbox-gl-native/pull/11921)) | |||
| * Fixed race conditions that could cause crashes when re-using `MGLMapSnapshotter` or using multiple snapshotters at the same time. ([#11831](https://github.com/mapbox/mapbox-gl-native/pull/11831)) | |||
| * Fixed an issue where an empty `MGLFeature`s array caused high CPU utilization. ([#11985](https://github.com/mapbox/mapbox-gl-native/pull/11985)) | |||
| * Improved offline download. ([#11284](https://github.com/mapbox/mapbox-gl-native/pull/11284)) | |||
There was a problem hiding this comment.
Let’s be a little more specific and say: “download performance.”
platform/ios/CHANGELOG.md
Outdated
| @@ -21,6 +23,9 @@ Mapbox welcomes participation and contributions from everyone. Please read [CONT | |||
| * Added custom `-hitTest:withEvent:` to `MGLSMCalloutView` to avoid registering taps in transparent areas of the standard annotation callout. ([#11939](https://github.com/mapbox/mapbox-gl-native/pull/11939)) | |||
| * Improved performance and memory impact of `MGLScaleBar`. ([#11921](https://github.com/mapbox/mapbox-gl-native/pull/11921)) | |||
| * Fixed race conditions that could cause crashes when re-using `MGLMapSnapshotter` or using multiple snapshotters at the same time. ([#11831](https://github.com/mapbox/mapbox-gl-native/pull/11831)) | |||
| * Fixed an issue where an empty `MGLFeature`s array caused high CPU utilization. ([#11985](https://github.com/mapbox/mapbox-gl-native/pull/11985)) | |||
| * Improved offline download. ([#11284](https://github.com/mapbox/mapbox-gl-native/pull/11284)) | |||
| * Fixed an issue that caused `MGLMapView visibleFeaturesAtPoint:]` return an empty features array when removing/adding features. ([#12076](https://github.com/mapbox/mapbox-gl-native/pull/12076)) | |||
There was a problem hiding this comment.
A few small tweaks:
Fixed an issue that caused
-[MGLMapView visibleFeaturesAtPoint:]to return an empty array when adding or removing features.
friedbunny
reviewed
Jun 11, 2018
platform/ios/CHANGELOG.md
Outdated
| @@ -11,6 +11,8 @@ Mapbox welcomes participation and contributions from everyone. Please read [CONT | |||
| ### Style layers | |||
|
|
|||
| * Added support for aggregate expressions as input values to `MGL_MATCH` expressions. ([#11866](https://github.com/mapbox/mapbox-gl-native/pull/11866)) | |||
| * Fixed a crash caused by `literal` expressions when used in non-data-driven properties. ([#11960](https://github.com/mapbox/mapbox-gl-native/pull/11960)) | |||
There was a problem hiding this comment.
This fix made it into ios-v4.0.2 (via #11961), so we don’t need to changelog it here.
fabian-guerra
force-pushed
the
fabian-ios-v4.1.0-beta.1
branch
from
b42cfcd
to
c48bdcd
Compare
|
Found another one: this line should link to its GitHub issue, so we need to add a link to #11784. |
fabian-guerra
force-pushed
the
fabian-ios-v4.1.0-beta.1
branch
from
c48bdcd
to
6430512
Compare
This was referenced Jun 11, 2018
friedbunny
approved these changes
Jun 11, 2018
fabian-guerra
force-pushed
the
fabian-ios-v4.1.0-beta.1
branch
from
6430512
to
1dfaa03
Compare
|
Going forward, changes such as these need to be merged to master first, then cherry-picked to the release branch. The release-chai branch won’t be merged back to master, so #12185 cherry-picks these changes into master. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Podspec bump and changelog updates.