Move Settings.bundle into included iosapp

[captainbarbosa]

Removes the settings target and gets rid of the included example Settings.bundle from this project, which would be moved to the ios-sdk-examples project in mapbox/ios-sdk-examples#204. Closes #12554.

This will not require a changelog entry.

[1ec5]

See #12554 (comment).

[captainbarbosa]

@1ec5 I went ahead with your suggestion and moved the Settings.bundle into iosapp as well as removed the unused Settings target, please let me know if I've missed something.

[1ec5]

In addition to these changes, package.sh will need to be updated to extract Settings.bundle from the built iosapp bundle in the build products.

Additionally, it may be necessary to update the localization addition process to include manually adding a localization of Root.strings – not sure if Xcode automatically detects that strings file as being localizable when it lies within a Settings.bundle.

[captainbarbosa]

@julianrex @friedbunny and I spoke about the direction of this PR. Since package.sh currently doesn't build iosapp, having it do so just to copy the Settings.bundle seems inefficient. We agreed that the Settings.bundle should remain in the iosapp but should not be packaged with the framework for now.

[1ec5]

Change these two lines:

mapbox-gl-native/platform/ios/scripts/package.sh

Line 141 in 3ca2050

cp -rv ${PRODUCTS}/${BUILDTYPE}-iphoneos/Settings.bundle ${OUTPUT}

mapbox-gl-native/platform/ios/scripts/package.sh

Line 166 in 3ca2050

cp -rv ${PRODUCTS}/${BUILDTYPE}-iphonesimulator/Settings.bundle ${OUTPUT}

to:

cp -rv platform/ios/app/Settings.bundle ${OUTPUT}

and nothing changes about the final built SDK.

[friedbunny]

@captainbarbosa Looks like Root.strings is still thought to exist in the SDK section of the Xcode project:

[friedbunny]

@captainbarbosa If we’re going to keep the localizations, please check that they work in their new home.

[captainbarbosa]

@friedbunny I tested on-device by changing the default language and checking the telemetry alert in iosapp:

[friedbunny]

@captainbarbosa The strings in that dialog are handled by the maps SDK directly (and will appear regardless of what’s in an app’s Settings.bundle).

Settings bundles are where apps define what extra settings will appear in their panels in the system’s settings (“Settings.app”), alongside typical permissions (location, etc).

[captainbarbosa]

@friedbunny Gotcha - I'm now noticing that the settings do localize the first time the language is changed, but then remain stuck on the first localization when the language is changed again. Not sure what the cause is but I'm seeing this on the device and with the simulator.

(After changing the default language from English to French and then to Japanese, the Settings remain localized to French.)

[friedbunny]

I'm now noticing that the settings do localize the first time the language is changed, but then remain stuck on the first localization when the language is changed again.

@captainbarbosa That also happens in master. It looks like Settings.app doesn’t use the Base localization in our Settings.bundle when it switches away from another localization and back to English. Explicitly adding an English localization for Settings.bundle (with the same strings as Base) fixes this issue. Disabling the Base localization (and moving it to English) also works.

@1ec5 Does this behavior seem like a bug to you, or are we doing something incorrectly?

References

• https://developer.apple.com/library/archive/qa/qa1828/_index.html#//apple_ref/doc/uid/DTS40014938

[1ec5]

I'm now noticing that the settings do localize the first time the language is changed, but then remain stuck on the first localization when the language is changed again.

Did you force-quit Settings between changing languages? If I’m not mistaken, the Settings application does cache its contents until you close it. What happens in other applications that specify localized settings pages?

[captainbarbosa]

@1ec5 force quitting the settings app doesn’t seem to work and other apps localize their custom settings as expected, so this only seems to be occurring with this project.

[captainbarbosa]

@friedbunny I added the English localization and its back to working as expected.

[friedbunny]

Did this ↓ end up being necessary, @captainbarbosa?

Additionally, it may be necessary to update the localization addition process to include manually adding a localization of Root.strings – not sure if Xcode automatically detects that strings file as being localizable when it lies within a Settings.bundle.

[captainbarbosa]

@friedbunny No, it was not necessary - @1ec5 and went through it together and localizations seemed to take with no issues 👍