Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Move example Settings.bundle outside of this Xcode project #12554

Closed
friedbunny opened this issue Aug 6, 2018 · 2 comments
Closed

Move example Settings.bundle outside of this Xcode project #12554

friedbunny opened this issue Aug 6, 2018 · 2 comments
Assignees
Labels
build iOS Mapbox Maps SDK for iOS refactor

Comments

@friedbunny
Copy link
Contributor

friedbunny commented Aug 6, 2018

We include an example Settings.bundle with a localized opt-out for Mapbox Telemetry (#2380). However, Xcode has never liked how we build this file and keeps throwing new warnings at us (#6948, #7698). In Xcode 8, 9, and 10b5, this is the warning we see:

Check dependencies

Warning: The Copy Bundle Resources build phase contains this target's Info.plist file 'framework/Settings.bundle/Root.plist’.

As our example Settings.bundle doesn’t appear to be well-used in its current iteration (few customer apps include this setting and, of the ones that do, I couldn’t find any that include the localized text), we should consider moving it to the ios-sdk-examples repo/project. This would remove the persistent warning and place it in more natural location (i.e., alongside other examples).

/cc @1ec5 @captainbarbosa

@friedbunny friedbunny added iOS Mapbox Maps SDK for iOS build refactor labels Aug 6, 2018
@captainbarbosa captainbarbosa self-assigned this Aug 7, 2018
@friedbunny
Copy link
Contributor Author

friedbunny commented Aug 9, 2018

Various public docs around this repo (and Mapbox generally) refer to this Settings.bundle, so those will also need to be audited.

There may also be localization scripts/keys to remove.

@1ec5
Copy link
Contributor

1ec5 commented Aug 11, 2018

Rather than removing the bundle outright, as in #12607, why not make it an ordinary resource in iosapp? That would resolve all the warnings, and it can benefit from translations from Transifex and iosapp gets a Settings bundle. We can still copy the bundle into the example project if that makes it more discoverable.

In theory, we could also automatically include the Settings bundle into an application if it’s installed via CocoaPods, along the lines of #3160, but that might be too aggressive.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build iOS Mapbox Maps SDK for iOS refactor
Projects
None yet
Development

No branches or pull requests

3 participants