Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios] specify plist-file for settings bundle #6948

Merged
merged 1 commit into from
Nov 8, 2016

Conversation

frederoni
Copy link
Contributor

Fixes #6947

Did this start with Xcode 8.1 or later?
Root.plist is usually picked up automatically from the settings bundle. Not sure why it doesn't all of a sudden.

@kkaefer 👀

@frederoni frederoni added iOS Mapbox Maps SDK for iOS ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold labels Nov 7, 2016
@mention-bot
Copy link

@frederoni, thanks for your PR! By analyzing the history of the files in this pull request, we identified @1ec5, @boundsj and @friedbunny to be potential reviewers.

@1ec5
Copy link
Contributor

1ec5 commented Nov 7, 2016

Unit tests are failing to compile on iOS (but not macOS, interestingly enough):

▸ Compiling MGLBackgroundStyleLayer.mm

❌  /Users/vagrant/git/platform/darwin/src/NSExpression+MGLAdditions.h:3:10: 'mbgl/style/filter.hpp' file not found

#include <mbgl/style/filter.hpp>
         ^


▸ Compiling NSComparisonPredicate+MGLAdditions.mm

❌  /Users/vagrant/git/platform/darwin/src/NSComparisonPredicate+MGLAdditions.h:3:10: 'mbgl/style/filter.hpp' file not found

#include <mbgl/style/filter.hpp>
         ^


xcode test exit code: 65
xcode test failed, error: exit status 65

Copy link
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this start with Xcode 8.1 or later?

That must be what introduced the failure.

Feel free to merge once we figure out what’s going on with the iOS unit tests.

@frederoni frederoni merged commit 3002023 into master Nov 8, 2016
@frederoni frederoni deleted the 6947-missing-plist-ref branch November 8, 2016 09:12
@boundsj boundsj added this to the ios-v3.4.0 milestone Nov 8, 2016
@friedbunny friedbunny added build and removed ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold labels Nov 23, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants