This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Change library loader to soloader #14890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zugaldia
approved these changes
Jun 11, 2019
| } catch (MapboxConfigurationException exception) { | ||
| Logger.e(LibraryLogger.TAG, "Couldn't load so file with relinker, application context missing, " | ||
| Logger.e(TAG, "Couldn't load so file with relinker, application context missing, " |
|
|
||
| @Override | ||
| public void load(String name) { | ||
| try { | ||
| Context context = Mapbox.getApplicationContext(); | ||
| ReLinker.log(new LibraryLogger()).loadLibrary(context, name); | ||
| init(Mapbox.getApplicationContext(),false); |
There was a problem hiding this comment.
What does false mean in this context? could its value bring any regressions? I'd add a comment or add a named variable.
There was a problem hiding this comment.
this references to exoPackage which is used when building with Buck.
Added a small comment with a link to exopackage.
yunikkk
reviewed
Jun 11, 2019
| @@ -23,36 +24,26 @@ | |||
| */ | |||
| @Override | |||
| public LibraryLoader getDefaultLibraryLoader() { | |||
| return new ReLinkerLibraryLoader(); | |||
| return new SoLibraryLoader(); | |||
| } | |||
|
|
|||
| /** | |||
| * Concrete implementation of a LibraryLoader using ReLinker. | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes our library loader from relinker to soloader. We initially switched to relinker based on advice given by Google in their NDK changelog. Now with getting feeedback as #14888 and #14428. Let's move forward using soloader from Facebook. It should be more stable.
Closes #14428
Closes #14888