Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

BC break: circle layer is drawn in different z-index #14844

Closed
hrach opened this issue Jun 4, 2019 · 9 comments · Fixed by #15065
Closed

BC break: circle layer is drawn in different z-index #14844

hrach opened this issue Jun 4, 2019 · 9 comments · Fixed by #15065
Assignees
@astojilj
Labels
bug Core The cross-platform C++ core, aka mbgl rendering
Milestone
release-picklejuice

Comments

@hrach
Copy link

hrach commented Jun 4, 2019

Hi, after upgrading to Android-8.1.0-alpha.1 from 7.4 our simple CircleLayer-s are drawn behind 3D building. SymbolLayer with images and icon stays on top.

Steps to reproduce

mapStyle.addLayer(circleLayer)
mapStyle.addLayer(markerLayer)

no other modification of laers, their z-index, etc.
2. Upgrade to com.mapbox.mapboxsdk:mapbox-android-sdk:8.1.0-alpha.1

Expected behavior

image

Actual behavior

image

Configuration

Android versions: Android Q
Device models: Pixel 2
Mapbox SDK versions: 8.1.0-alpha.1
@tobrun
Copy link
Member

tobrun commented Jun 4, 2019

cc @tmpsantos

@tobrun tobrun added the Core The cross-platform C++ core, aka mbgl label Jun 4, 2019
@hrach
Copy link
Author

hrach commented Jun 12, 2019

This issue is already present in 8.0.1, so we are blocked from getting fix for #14890

@kkaefer
Copy link
Member

kkaefer commented Jun 12, 2019

/cc @ansis

@camelCaseSucks
Copy link

camelCaseSucks commented Jun 15, 2019 •
edited
Loading

I came here to report this. Example attached.

mapbox-7 3 0
mapbox-8 0 1

MapboxTest.tar.gz

@kkaefer
Copy link
Member

kkaefer commented Jun 19, 2019

This was probably broken by #14526

@hrach
Copy link
Author

hrach commented Jun 25, 2019

Hi, I'd like to ask if there is any eta - e.g. days/weeks/months. Because if it takes longer, we will upgrade the app regardless this bug.

@tmpsantos
Copy link
Contributor

Hi, I'd like to ask if there is any eta - e.g. days/weeks/months. Because if it takes longer, we will upgrade the app regardless this bug.

I can't give you a concrete ETA, but I don't see bandwidth available in our team to work on this issue for the next two weeks.

@tmpsantos tmpsantos mentioned this issue Jun 25, 2019
Closed
@astojilj astojilj mentioned this issue Jul 6, 2019
Closed
@chloekraw
Copy link
Contributor

Hi, I'd like to ask if there is any eta - e.g. days/weeks/months. Because if it takes longer, we will upgrade the app regardless this bug.

@hrach, we are aiming to get a fix in the next release (5.2 on iOS / 8.2 on Android), so weeks. thanks for your patience.

@chloekraw
Copy link
Contributor

@mapbox/maps-ios @mapbox/maps-android, we should also release patches of iOS 5.0, 5.1 and Android 8.0, 8.1 when this is fixed.

astojilj added a commit that referenced this issue Jul 7, 2019
@astojilj
Fix layers rendering after fill-extrusion
a89473c 
This fixes following issues:
* Fix some false passing combinations/fill-extrusion-translucent--XXXX tests
* Fix and enable other, failing but ignored, combinations/fill-extrusion-translucent--XXXX tests
* Fix rendering of layers that are on top of fill-extrusion layers

state.getProjMatrix(nearClippedProjMatrix, 100) caused that tests with size 64x64 were not
rendering fill extrusions: far plane calculated as 96.9 and near plane set to 100 was the cause.
near plane is changed from hardcoded 100 to depend on state.getCameraToCenterDistance() - producing
similar value but one that follows max zoom.

This caused that e.g. combinations/fill-extrusion-translucent--fill-opaque was falsely passing as
only fill-opaque layer got rendered.

combinations/fill-extrusion-translucent--XXXX tests expose regression #14844 (comment) in #14844, #14779.

Fix (opaquePassCutoff, is3D) is ported from mapbox/mapbox-gl-js#7821

Fixes: #14844, #14779, #15039
@astojilj astojilj mentioned this issue Jul 7, 2019
Merged
astojilj added a commit that referenced this issue Jul 9, 2019
@astojilj
Fix layers rendering after fill-extrusion
c852c04 
This fixes following issues:
* Fix some false passing combinations/fill-extrusion-translucent--XXXX tests
* Fix and enable other, failing but ignored, combinations/fill-extrusion-translucent--XXXX tests
* Fix rendering of layers that are on top of fill-extrusion layers

state.getProjMatrix(nearClippedProjMatrix, 100) caused that tests with size 64x64 were not
rendering fill extrusions: far plane calculated as 96.9 and near plane set to 100 was the cause.
near plane is changed from hardcoded 100 to depend on state.getCameraToCenterDistance() - producing
similar value but one that follows max zoom.

This caused that e.g. combinations/fill-extrusion-translucent--fill-opaque was falsely passing as
only fill-opaque layer got rendered.

combinations/fill-extrusion-translucent--XXXX tests expose regression #14844 (comment) in #14844, #14779.

Fix (opaquePassCutoff, is3D) is ported from mapbox/mapbox-gl-js#7821

Fixes: #14844, #14779, #15039
astojilj added a commit that referenced this issue Jul 9, 2019
@astojilj
Fix layers rendering after fill-extrusion
2c5528e 
This fixes following issues:
* Fix some false passing combinations/fill-extrusion-translucent--XXXX tests
* Fix and enable other, failing but ignored, combinations/fill-extrusion-translucent--XXXX tests
* Fix rendering of layers that are on top of fill-extrusion layers

state.getProjMatrix(nearClippedProjMatrix, 100) caused that tests with size 64x64 were not
rendering fill extrusions: far plane calculated as 96.9 and near plane set to 100 was the cause.
near plane is changed from hardcoded 100 to depend on state.getCameraToCenterDistance() - producing
similar value but one that follows max zoom.

This caused that e.g. combinations/fill-extrusion-translucent--fill-opaque was falsely passing as
only fill-opaque layer got rendered.

combinations/fill-extrusion-translucent--XXXX tests expose regression #14844 (comment) in #14844, #14779.

Fix (opaquePassCutoff, is3D) is ported from mapbox/mapbox-gl-js#7821

Fixes: #14844, #14779, #15039
@friedbunny friedbunny added this to the release-picklejuice milestone Jul 9, 2019
astojilj added a commit that referenced this issue Jul 19, 2019
@astojilj
Fix wrong #15065 nit fix
7cb86a2 
Change in 3ffc14a
was a typo while addresssing review nit: while it didn't affect render tests it doesn't work properly in all cases.

Fixes: #14844, #14779, #15039
@astojilj astojilj mentioned this issue Jul 19, 2019
Merged
astojilj added a commit that referenced this issue Jul 19, 2019
@astojilj
Fix wrong #15065 nit fix
d7f28c3 
Change in 3ffc14a
was a typo while addresssing review nit: while it didn't affect render tests it doesn't work properly in all cases.

Fixes: #14844, #14779, #15039
astojilj added a commit that referenced this issue Jul 19, 2019
@astojilj
Fix wrong #15065 nit fix
1ae7ff4 
Change in 3ffc14a
was a typo while addresssing review nit: while it didn't affect render tests it doesn't work properly in all cases.

Fixes: #14844, #14779, #15039
astojilj added a commit that referenced this issue Jul 23, 2019
@astojilj
Fix wrong #15065 nit fix
cefec34 
Change in 3ffc14a
was a typo while addresssing review nit: while it didn't affect render tests it doesn't work properly in all cases.

Fixes: #14844, #14779, #15039
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@astojilj astojilj

Labels
bug Core The cross-platform C++ core, aka mbgl rendering
Projects
None yet
Milestone
release-picklejuice
Development

Successfully merging a pull request may close this issue.

Fix layers rendering after fill-extrusion mapbox/mapbox-gl-native
8 participants
@kkaefer @hrach @astojilj @tmpsantos @friedbunny @tobrun @chloekraw @camelCaseSucks