This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Fix wrong #15065 nit fix #15172
Merged
Fix wrong #15065 nit fix #15172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshalamov
approved these changes
Jul 19, 2019
alexshalamov
added
the
needs changelog
pozdnyakov
approved these changes
Jul 19, 2019
|
@alexshalamov Edit: added render test mapbox/mapbox-gl-js#8515 to verify that this isn't causing rendering regression. Performance impact would be coming from moving all layers from fill pass to translucent pass (while still rendering properly). |
astojilj
removed
the
needs changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change in 3ffc14a
was a typo while addressing review nit: while it doesn't affect rendering it could affect performance.
Because of the potential performance impact, It is important to get it to current beta releases (added beta blocker label). I'm incorporating it to backports of #15065 to nectar and oolong.
Edit: added render test mapbox/mapbox-gl-js#8515 to verify that this isn't causing rendering regression. Performance impact would be coming from moving all layers from fill pass to translucent pass (while still rendering properly).
Related to: #14844, #14779, #15039