Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Do not clear native layers and sources when style is reloading #15513

Merged
merged 1 commit into from
Aug 29, 2019

Conversation

LukasPaczos
Copy link
Contributor

This prevents unnecessary layers blink when the same components are re-added after the style reload.

Before:
ezgif com-video-to-gif (18)

After:
ezgif com-video-to-gif (19)

/cc @Guardiola31337

This prevents unnecessary layers blink when the same components are re-added after the style reload.
@LukasPaczos LukasPaczos added the Android Mapbox Maps SDK for Android label Aug 28, 2019
@LukasPaczos LukasPaczos added this to the release-ristretto milestone Aug 28, 2019
@LukasPaczos
Copy link
Contributor Author

Expected changelog entry:

### Bug fixes
 - Fixed unnecessary layers blink when the same components are re-added after the style reload [#15513](https://github.com/mapbox/mapbox-gl-native/pull/15513)

@LukasPaczos LukasPaczos added the needs changelog Indicates PR needs a changelog entry prior to merging. label Aug 28, 2019
@Guardiola31337
Copy link
Contributor

We've tested OP (8.4.0-SNAPSHOT) downstream in the Navigation SDK and the puck is not blinking anymore 👀

routes_blinking_8_4_0_SNAPSHOT

The routes are still blinking though. I'll report back here when mapbox/mapbox-navigation-android#2039 is fixed ensuring OP works for all the layers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android needs changelog Indicates PR needs a changelog entry prior to merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants