Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the logic that hides / removes route layers when the style changes #2039

Closed
Guardiola31337 opened this issue Aug 30, 2019 · 4 comments · Fixed by #2262
Closed

Remove the logic that hides / removes route layers when the style changes #2039

Guardiola31337 opened this issue Aug 30, 2019 · 4 comments · Fixed by #2262
Assignees

Comments

@Guardiola31337
Copy link
Contributor

As seen in mapbox/mapbox-gl-native#15513 the location puck being a runtime layer is added to the style and as a precaution to avoid the possibility of querying any layers while the style is changing, it was hidden.

The same thing happens in the Navigation SDK with the routes (are also runtime layers) and you get a blinking effect if the style is reloaded 👀

route_blinking_on_style_reloaded

mapbox/mapbox-gl-native#15513 prevents unnecessary layers blink when the same components are re-added after the style reload. Although, puck is not blinking anymore, the routes still do 👀

routes_blinking_8_4_0_SNAPSHOT

We need to remove the logic that hides / removes route layers when the style changes, which is not necessary as it's handled upstream by the Maps SDK as part of mapbox/mapbox-gl-native#15513

cc @LukasPaczos

@Guardiola31337
Copy link
Contributor Author

This is unblocked now as was included in https://github.com/mapbox/mapbox-gl-native/releases/tag/android-v8.4.0-alpha.1 and Maps SDK v8.4.0 was released 🎉

@AnnaStaley
Copy link

AnnaStaley commented Oct 28, 2019

Do you have a timeline for this fix?
cc @LukasPaczos
Thank you!

@andrlee
Copy link
Contributor

andrlee commented Oct 28, 2019

this ticket can be closed as it was fixed with mapbox/mapbox-gl-native#15513

@andrlee andrlee closed this as completed Oct 28, 2019
@LukasPaczos
Copy link

mapbox/mapbox-gl-native#15513 is only a piece of the puzzle. Per voice with @Guardiola31337 and #2039 (comment) the sources/layers setup will have to be also adjusted on the navigation side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants