This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Allow for Mapbox logo to be placed on either side of the map. #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While I appreciate the code here, we've got a discussion already in #1781 about generic moving of the logo as well as the attribution button and the compass, why this gets complex, and why we will probably just stick with hiding and showing for now. |
andrewcar
reviewed
Oct 29, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a property to choose whether the Mapbox logo should be shown on the right or left bottom corner of the maps. Defaults to bottom left, the same as current behavior. Having a bottom right placement option is convenient for developers who already have other UI components in the bottom left corner.