This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
cameraThatFitsCoordinateBounds #4790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
added
iOS
|
Note that the result of |
Closed
1ec5
force-pushed
the
1ec5-camera-fit
branch
2 times, most recently
from
783d633
to
e7aac28
Compare
Added an API to get a camera that you can pass into -[MGLMapView setCamera:] that fits the given coordinate bounds, by analogy with -[MKMapView regionThatFits:] or -[MKMapView mapRectThatFits:edgePadding:]. Added mbgl::Map::getCameraOptions() for getting the current camera options more conveniently.
1ec5
added a commit
that referenced
this pull request
Apr 23, 2016
Followup to #4790. Fixed a regression preventing the direction and pitch from being persisted across sessions.
|
df0d118 fixes a regression this change introduced that prevented the map’s previous direction and pitch from being persisted by state restoration. Thankfully, centralizing this code means we don’t have to do so much of this conversion anymore. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an API to get a camera that you can pass into
-[MGLMapView setCamera:]that fits the given coordinate bounds, by analogy with-[MKMapView regionThatFits:]or-[MKMapView mapRectThatFits:edgePadding:].Added
mbgl::Map::getCameraOptions()for getting the current camera options in fewer lines of code – less opportunity to forget a field.@friedbunny, can you double-check that I haven’t flubbed anything with respect to edge insets / padding?