This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Partial implementation of runtime styling API for node bindings #5318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There will be some conflicts with #5288; I'm going to wait for the merge there and then rebase and resolve them here. |
jfirebaugh
force-pushed
the
node-style-api
branch
4 times, most recently
from
30948de
to
1b4b3b1
Compare
Rewrite enum.hpp in such a way that parseConstant can be defined generically for all enumerated types. While there, properly validated enumerated property values.
For runtime styling, it needs to overwrite any existing value.
jfirebaugh
force-pushed
the
node-style-api
branch
from
1b4b3b1
to
3f5ea16
Compare
3 tasks
This was referenced Mar 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enough to pass the three basic runtime styling tests in test-suite. 🎉
Still TODO:
setLayoutPropertysetPaintPropertywith a function