This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
fix #5983: ignore viewport no-ops #6060
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incanus
added
iOS
…-gl-native into 5983-ignore-viewport-noops
| && _centerCoordinate.longitude == otherCamera.centerCoordinate.longitude | ||
| && _altitude == otherCamera.altitude | ||
| && _pitch == otherCamera.pitch && _heading == otherCamera.heading); | ||
| NSAssert([otherCamera isKindOfClass:[self class]], @"must compare two cameras"); |
There was a problem hiding this comment.
The method takes an id, which implies you can pass in any object. Do other classes assert when you attempt to compare to something of a different class?
There was a problem hiding this comment.
Good point. 5fba4e6
| @@ -34,6 +34,14 @@ NS_INLINE mbgl::LatLngBounds MGLLatLngBoundsFromCoordinateBounds(MGLCoordinateBo | |||
| MGLLatLngFromLocationCoordinate2D(coordinateBounds.ne)); | |||
| } | |||
|
|
|||
| NS_INLINE void MGLLocationCoordinatesFromCoordinateBounds(MGLCoordinateBounds coordinateBounds, CLLocationCoordinate2D *coordinates) { | |||
| assert(sizeof(coordinates) == 4 * sizeof(CLLocationCoordinate2D)); | |||
There was a problem hiding this comment.
Tried, but can't do that in NS_INLINE; it requires the existence of self.
There was a problem hiding this comment.
My bad, you want NSCAssert, because we're in a C function that has no access to self.
1ec5
added
⚠️ DO NOT MERGE
also migrate instances of `void (^)(void)` to `dispatch_block_t`
This was referenced Nov 20, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress towards fixing #5983. We may want to do some of this not just at the mobile bindings layer, but also in core for completeness.
/cc @1ec5 @friedbunny