This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Wrap camera heading #7724
Merged
Wrap camera heading #7724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
added
bug
iOS
|
@1ec5, thanks for your PR! By analyzing this pull request, we identified @incanus, @boundsj and @friedbunny to be potential reviewers. |
|
I put this PR on the v3.4.1 milestone, because it’s so close to the v3.4.0 release and we shipped this regression in v3.3.0. However, I’m open to moving it up to v3.4.0 if there’s a need for the fix sooner. |
1ec5
force-pushed
the
1ec5-camera-wrap-7723
branch
from
13bd14f
to
5edbec2
Compare
incanus
suggested changes
Jan 23, 2017
| [tester.mapView twoFingerRotateAtPoint:tester.mapView.center angle:-45]; | ||
|
|
||
| XCTAssertGreaterThanOrEqual(fabs(tester.mapView.direction - startAngle), | ||
| -20, |
There was a problem hiding this comment.
The absolute value of one number will always be greater than or equal to another, negative number.
1ec5
force-pushed
the
1ec5-camera-wrap-7723
branch
from
5edbec2
to
1fa4c07
Compare
incanus
approved these changes
Jan 24, 2017
This was referenced Jan 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue causing MGLMapView’s
camera’sheadingto be set to a negative value, indicating an undefined heading, when the map view faces northwest. The heading is now wrapped to between zero and 360 degrees, for consistency with MGLMapView’sdirectionproperty.Fixes #7723.
/cc @friedbunny