v10 default styles

[1ec5]

Upgraded from v9 default styles to v10 wherever the developer expects to get the latest and greatest, as well as in a couple tests where it may be beneficial to ensure that we can handle a two-digit version number in the style URL.

Added the Traffic Day v2 and Traffic Night v2 styles, which are now documented as part of the styles API in Mapbox API Documentation.

This PR also partially reverses the decision in #4702 to require iOS and macOS developers to specify a style version number when calling one of MGLStyle’s style URL factory methods. The versioned methods are still there, but the unversioned methods are no longer deprecated. This change makes the iOS and macOS SDKs consistent with the Android and Qt SDKs, which never followed suit and kept their unversioned constants.

Hold until the v10 styles are live.

/cc @tobrun @friedbunny @tmpsantos @amyleew

[mention-bot]

@1ec5, thanks for your PR! By analyzing this pull request, we identified @bleege, @tmpsantos and @jfirebaugh to be potential reviewers.

[tmpsantos]

@1ec5 thanks!

Just food for thought, not exactly related to this PR, but if a style change also upgrades the tile source, we need to think about a way of not rendering tiles on the offline database useless.

[1ec5]

Can you elaborate? Is the concern that the user would have to redownload a region's tiles if the v10 Streets style uses a newer version of the Streets source (say, v8) than the v9 Streets style? Styles are somewhat tightly coupled to the sources they reference, so I'm not sure how we'd address that issue without adding custom tile migration logic for individual sources.

[tmpsantos]

Styles are somewhat tightly coupled to the sources they reference

Makes sense. Yeah, in this case, if you wanna keep the offline database, better not upgrade the style. Thanks!

[amyleew]

@1ec5 - v9 updates and limited v10 styles are now ready to roll in. Please note changelog for specifics.

[zugaldia]

@1ec5 Thanks for updating the Android versions as well, is there any tail work required on Android once this PR gets merged?

[1ec5]

v10 has been released for Streets, Outdoors, and Satellite Streets. Apparently the styles are versioned separately, so Light, Dark, and Satellite are still stuck on v9. This PR will need to be reworked to reflect that fact:

• Remove mbgl::util::default_styles::currentVersion and figure out what to do about code that uses it
• Tweak MGLStyleDefaultVersion’s documentation to say it’s the version of the default style, not “the default version of the suite of default styles”
• Hard-code version numbers in tests, making it much more likely that versions will get out of sync in the future

[1ec5]

Not critical for v3.4.1, and no Mapbox-wide timetable for releasing the v10 styles. Moving off the v3.4.1 milestone.

[1ec5]

Can we log that to the console for Debug builds only? I think disabling runtime styling for certain URLs could also lead to very weird behavior and increases the complexity.

Yes, a log message would certainly be doable. If our goal is to alert about programmer error, though, maybe it should be present in release builds as well, but once per session, like the warning about using floats in predicates.

As far as disabling runtime styling for unversioned URLs, I think this is something that MGLMapView would be able to handle: -[MGLMapView setStyleURL:] would detect the x-darwin-versioned parameter and potentially strip it, and -[MGLMapView style] would remain nil even after -[MGLMapViewDelegate mapView:styleDidFinishLoading:] is called. But you’re right that a log message would be friendlier. Disabling the runtime styling API would be rather draconian, only remotely desirable if we find that everyone is using unversioned style URLs with the runtime styling API.

[tobrun]

🤖 👍

[kkaefer]

Merge conflict

[1ec5]

Whoops, I missed that one – good catch! Fixed in 1d0e203.

fixed

[1ec5]

We could append a query parameter like ?x-darwin-versioned=false to the returned URL; MGLMapView could track the usage of such URLs and disable or booby-trap the runtime styling API.

Tracking as possible tail work in #8971.

[1ec5]

Cherry-picking into the release-ios-v3.6.0-android-v5.1.0 branch in #8972.