This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Add version argument to class members of Style, deprecate older ones #4702

Closed

tobrun opened this issue Apr 14, 2016 · 4 comments · Fixed by #4759

Labels

Milestone

Member

tobrun commented Apr 14, 2016 •

edited

Loading

~~Add a version argument to the Style class members. Each member documentation would say what the current latest version is, “as of” a certain date. Deprecate the unversioned methods.~~

Update:

For iOS:

Add a version argument to the MGLStyle class methods. Each method’s documentation would say what the current latest version is, “as of” a certain date. Deprecate the unversioned methods.

For Android:

Use same system as iOS, deprecate old Style.java class.

In line with deprecation of the Emerald style in #4577 .

The text was updated successfully, but these errors were encountered:

tobrun added the Android label

tobrun added this to the android-v4.1.0 milestone

1ec5 added the iOS label

Contributor

jfirebaugh commented Apr 14, 2016

For Android, we should switch to a function-based approach like iOS: Style.mapboxSatelliteStyleURL(int version). That way we don't have to modify Style for each new style version release.

Member Author

tobrun commented Apr 18, 2016

@jfirebaugh thank you for the input,
I updated the requirements above and divided them in iOS and Android specifically.

1ec5 added a commit that referenced this issue


[core, ios, osx] Version default style URL APIs; deprecated Emerald

5c0b647

Updated default styles from v8 to v9. Deprecated the MGLMapView class methods in favor of new methods that take a version parameter. Deprecated Emerald outright in favor of Outdoors. Replaced usage of the unversioned MGLStyle methods with the corresponding versioned methods and MGLStyleCurrentVersion to ensure consistency.

Expanded MGLStyle unit tests to also assert that MGLStyle has the right number of style URL methods.

Replaced Emerald with Outdoors in iosapp and osxapp.

Fixes the iOS and OS X side of #4577 and #4702.

1ec5 mentioned this issue

Version default style URL APIs; deprecate Emerald #4759

Merged

6 tasks

Contributor

1ec5 commented Apr 20, 2016

Style URL APIs are getting versioned in the iOS and OS X SDKs in #4759.

Member Author

tobrun commented Apr 20, 2016

@1ec5 great,
I will create a branch from #4759 and create a PR to get the Android changes in the same PR.

1ec5 added a commit that referenced this issue


[core, ios, osx] Version default style URL APIs; deprecated Emerald

61b8409

Updated default styles from v8 to v9. Deprecated the MGLMapView class methods in favor of new methods that take a version parameter. Deprecated Emerald outright in favor of Outdoors. Replaced usage of the unversioned MGLStyle methods with the corresponding versioned methods and MGLStyleCurrentVersion to ensure consistency.

Expanded MGLStyle unit tests to also assert that MGLStyle has the right number of style URL methods and that they’re all public. Linked the OS X SDK unit test bundle to libmbgl-core.a. Removed an unnecessary dependency on osxapp.

Replaced Emerald with Outdoors in iosapp and osxapp.

Fixes the iOS and OS X side of #4577 and #4702.

1ec5 added a commit that referenced this issue


[core, ios, osx] Version default style URL APIs; deprecated Emerald

c2dee9b

Updated default styles from v8 to v9. Deprecated the MGLMapView class methods in favor of new methods that take a version parameter. Deprecated Emerald outright in favor of Outdoors. Replaced usage of the unversioned MGLStyle methods with the corresponding versioned methods and MGLStyleCurrentVersion to ensure consistency.

Expanded MGLStyle unit tests to also assert that MGLStyle has the right number of style URL methods and that they’re all public. Linked the OS X SDK unit test bundle to libmbgl-core.a. Removed an unnecessary dependency on osxapp.

Replaced Emerald with Outdoors in iosapp and osxapp.

Fixes the iOS and OS X side of #4577 and #4702.

tobrun added a commit that referenced this issue


[android] #4702 - upgrade default styles, deprecate Style string defi…

81ddb5a

…nition in favour versioned styling methods.

tobrun mentioned this issue

[android] #4702 - upgrade default styles for Android #4812

Merged

tobrun added a commit that referenced this issue


[android] #4702 - fix order styles, added test to check style version…

0b9b2a3

… of the test app.

tobrun added a commit that referenced this issue


[android] #4702 - added url + current version to javadoc, added int r…

0d91ed9

…ange to version parameter.

tobrun added a commit that referenced this issue


[android] #4702 - removed double int range annotation

8b95860

tobrun added a commit that referenced this issue


[android] #4702 - removed int range annotation, added us locale and c…

ff387ef

…losed ul tags.

tobrun added a commit that referenced this issue


[android] #4702 - upgrade default styles, deprecate Style string defi…

5b007f8

…nition in favour versioned styling methods.

1ec5 added a commit that referenced this issue


[core, ios, osx] Version default style URL APIs; deprecated Emerald

b25b12b

Updated default styles from v8 to v9. Deprecated the MGLMapView class methods in favor of new methods that take a version parameter. Deprecated Emerald outright in favor of Outdoors. Replaced usage of the unversioned MGLStyle methods with the corresponding versioned methods and MGLStyleCurrentVersion to ensure consistency.

Expanded MGLStyle unit tests to also assert that MGLStyle has the right number of style URL methods and that they’re all public. Linked the OS X SDK unit test bundle to libmbgl-core.a. Removed an unnecessary dependency on osxapp.

Replaced Emerald with Outdoors in iosapp and osxapp.

Fixes the iOS and OS X side of #4577 and #4702.

1ec5 pushed a commit that referenced this issue


[android] #4702 - upgrade default styles, deprecate Style string defi…

ad08e74

…nition in favour versioned styling methods.

1ec5 added a commit that referenced this issue


[core, ios, osx] Version default style URL APIs; deprecated Emerald

Updated default styles from v8 to v9. Deprecated the MGLMapView class methods in favor of new methods that take a version parameter. Deprecated Emerald outright in favor of Outdoors. Replaced usage of the unversioned MGLStyle methods with the corresponding versioned methods and MGLStyleCurrentVersion to ensure consistency.

Expanded MGLStyle unit tests to also assert that MGLStyle has the right number of style URL methods and that they’re all public. Linked the OS X SDK unit test bundle to libmbgl-core.a. Removed an unnecessary dependency on osxapp.

Replaced Emerald with Outdoors in iosapp and osxapp.

Fixes the iOS and OS X side of #4577 and #4702.

1ec5 pushed a commit that referenced this issue


[android] #4702 - upgrade default styles, deprecate Style string defi…

…nition in favour versioned styling methods.

1ec5 added a commit that referenced this issue


[core, ios, osx] Version default style URL APIs; deprecated Emerald

8e50f00

Updated default styles from v8 to v9. Deprecated the MGLMapView class methods in favor of new methods that take a version parameter. Deprecated Emerald outright in favor of Outdoors. Replaced usage of the unversioned MGLStyle methods with the corresponding versioned methods and MGLStyleCurrentVersion to ensure consistency.

Expanded MGLStyle unit tests to also assert that MGLStyle has the right number of style URL methods and that they’re all public. Linked the OS X SDK unit test bundle to libmbgl-core.a. Removed an unnecessary dependency on osxapp.

Replaced Emerald with Outdoors in iosapp and osxapp.

Fixes the iOS and OS X side of #4577 and #4702.

Cherry-picked from 9273433.

1ec5 added a commit that referenced this issue


[core, ios, osx] Version default style URL APIs; deprecated Emerald

2a4eead

Updated default styles from v8 to v9. Deprecated the MGLMapView class methods in favor of new methods that take a version parameter. Deprecated Emerald outright in favor of Outdoors. Replaced usage of the unversioned MGLStyle methods with the corresponding versioned methods and MGLStyleCurrentVersion to ensure consistency.

Expanded MGLStyle unit tests to also assert that MGLStyle has the right number of style URL methods and that they’re all public. Linked the OS X SDK unit test bundle to libmbgl-core.a. Removed an unnecessary dependency on osxapp.

Replaced Emerald with Outdoors in iosapp and osxapp.

Fixes the iOS and OS X side of #4577 and #4702.

1ec5 pushed a commit that referenced this issue


[android] #4702 - upgrade default styles, deprecate Style string defi…

da422ff

…nition in favour versioned styling methods.

1ec5 closed this as completed in #4759

1ec5 added a commit that referenced this issue


[core, ios, osx] Version default style URL APIs; deprecated Emerald

1d37eb3

Updated default styles from v8 to v9. Deprecated the MGLMapView class methods in favor of new methods that take a version parameter. Deprecated Emerald outright in favor of Outdoors. Replaced usage of the unversioned MGLStyle methods with the corresponding versioned methods and MGLStyleCurrentVersion to ensure consistency.

Expanded MGLStyle unit tests to also assert that MGLStyle has the right number of style URL methods and that they’re all public. Linked the OS X SDK unit test bundle to libmbgl-core.a. Removed an unnecessary dependency on osxapp.

Replaced Emerald with Outdoors in iosapp and osxapp.

Fixes the iOS and OS X side of #4577 and #4702.

Cherry-picked from 2a4eead.

bleege mentioned this issue

Use Locale Constant In Style #5068

Closed

tobrun mentioned this issue

deprecation cleanup for 5.0.0 #7767

Merged

1ec5 mentioned this issue

v10 default styles #6301

Merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.