deprecation cleanup for 5.0.0 #7767
Conversation
[android] - remove deprecation annoation for setStyle [android] - dismiss tracking on gesture deprecation cleanup
| @@ -824,7 +824,6 @@ public void setStyleUrl(@NonNull String url) { | |||
| * @deprecated use {@link #setStyleUrl(String)} instead with versioned url methods from {@link Style} | |||
| */ | |||
| @UiThread | |||
| @Deprecated | |||
There was a problem hiding this comment.
This isn't removing the method, only the annotation.
There was a problem hiding this comment.
That is correct. There is actually some back story behind this deprecation.. At some point in time we introduced versioned style methods. This introduced the @Deprecated annotation to setStyleUrl. Not much after that, this was reverted in #5193 but the deprecated annotation was not removed. I'm definitely open to revisit the decisions made in these issues, I actually don't have a strong opinion on this, but I think removing the annotation in this PR reflects the current Style.java implementation.
There was a problem hiding this comment.
I think removing the annotation in this PR reflects the current Style.java implementation
In that case, let's leave like you put it.
Closes #7575, finalising public api for 5.0.0, cleanup deprecation
This PR doesn't include the removal of TextureView.
As proposed here, I'm going to pick this up with #5766.
Review @zugaldia