Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Rename qt5 formula to qt #8692

Merged
merged 1 commit into from
Apr 9, 2017
Merged

Rename qt5 formula to qt #8692

merged 1 commit into from
Apr 9, 2017

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Apr 8, 2017

Updated the Qt5 macOS Bitrise bot’s configuration to reflect the qt5 formula’s rename to qt in Homebrew/homebrew-core@b92c519.

Fixes #8691.

@1ec5 1ec5 added build Qt Mapbox Maps SDK for Qt, aka Qt Location Mapbox GL labels Apr 8, 2017
@1ec5 1ec5 self-assigned this Apr 8, 2017
@1ec5 1ec5 requested a review from brunoabinader April 8, 2017 22:47
@1ec5
Copy link
Contributor Author

1ec5 commented Apr 8, 2017

Once this change lands, I’ll cherry-pick it to the release-ios-v3.5.0-android-v5.0.0 branch to unblock #8684.

@1ec5 1ec5 force-pushed the 1ec5-qt5-brew-8691 branch from ad1bf50 to 3172a97 Compare April 8, 2017 22:55
friedbunny
friedbunny approved these changes Apr 9, 2017
View reviewed changes
Copy link
Contributor

@friedbunny friedbunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bitrise... 😐

@1ec5
Copy link
Contributor Author

1ec5 commented Apr 9, 2017

Our workflow invokes brew install, which triggers a brew update anyways, so even if Bitrise hadn’t upgraded the VM, I think this failure would’ve occurred due to the changes in Homebrew itself.

@1ec5 1ec5 merged commit 3172a97 into master Apr 9, 2017
@1ec5 1ec5 deleted the 1ec5-qt5-brew-8691 branch April 9, 2017 02:58
@1ec5 1ec5 mentioned this pull request Apr 9, 2017
Merged
@friedbunny
Copy link
Contributor

friedbunny commented Apr 9, 2017 •
edited
Loading

Hrm, so the problem is us symlinking hardcoded paths — homebrew’s aliasing procedure still allows for qt5 in all of the brew commands we use, e.g.:

$ brew list --versions qt5
qt 5.8.0_2

We could avoid hardcoded paths by using brew --cellar:

$ brew --cellar qt5
/usr/local/Cellar/qt

@1ec5 1ec5 mentioned this pull request Apr 10, 2017
Merged
@1ec5
Copy link
Contributor Author

1ec5 commented Apr 10, 2017

We could avoid hardcoded paths by using brew --cellar

Done in #8698.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@friedbunny friedbunny friedbunny approved these changes

@brunoabinader brunoabinader Awaiting requested review from brunoabinader

Assignees

@1ec5 1ec5

Labels
build Qt Mapbox Maps SDK for Qt, aka Qt Location Mapbox GL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1ec5 @friedbunny