This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Avoid hardcoding Qt cellar path #8698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedbunny
reviewed
Apr 10, 2017
platform/qt/bitrise-qt5.yml
Outdated
| @@ -19,9 +19,10 @@ workflows: | |||
| brew install qt | |||
| brew link qt --force | |||
| brew linkapps qt | |||
| export HOMEBREW_QT5_CELLAR=$(brew --cellar qt5) | |||
There was a problem hiding this comment.
I suppose we may as well use qt in the command here, too, for consistency.
There was a problem hiding this comment.
Thanks, fixed in 5a46769.
1ec5
force-pushed
the
1ec5-qt5-brew-cellar-8691
branch
from
5a5062f to
5a46769
Compare
friedbunny
approved these changes
Apr 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change avoids hard-coding the path to the Homebrew cellar for the
qtformula, per #8692 (comment)./cc @friedbunny @brunoabinader