This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] - convert camera position values coming from core #8794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivovandongen
approved these changes
Apr 21, 2017
| @@ -109,7 +109,7 @@ PointF getFocalPoint() { | |||
| */ | |||
| public void update(final double bearing) { | |||
| // compass needs reverse bearing #8123 | |||
tobrun
force-pushed
the
8792-compassview-broken
branch
from
79863c9
to
4589b01
Compare
tobrun
added a commit
that referenced
this pull request
Apr 21, 2017
tobrun
added a commit
that referenced
this pull request
Apr 21, 2017
* [android] - move calculation of LatLngBounds to core * [core] Ignore shortest path in Map::pixelForLatLng * [android] - convert camera position values coming from core (#8794)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8792, regression from #4796, the camera position values weren't correctly converted. (eg. angle + pitch from core are in rad while in the Android binding they are in degrees).