Fix lineIntersects to align with Turf.js implementation #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
pengdev
reviewed
Jan 18, 2022
| @@ -346,11 +346,11 @@ private static LineIntersectsResult lineIntersects(double line1StartX, double li | |||
| + (varA * (line1EndY - line1StartY))).build(); | |||
|
|
|||
| // if line1 is a segment and line2 is infinite, they intersect if: | |||
| if (varA > 0 && varA < 1) { | |||
| if (varA >= 0 && varA <= 1) { | |||
There was a problem hiding this comment.
could we add tests for the changes?
There was a problem hiding this comment.
@pengdev Thanks, I added the test.
OttyLab
force-pushed
the
fix-intersects
branch
from
8af7d68 to
b03d6ab
Compare
|
I'd be in favor of merging this PR with #1348 and using the public API to test the boundaries, instead of using reflection. |
pengdev
reviewed
Jan 25, 2022
| public void testLineIntersects() throws | ||
| NoSuchMethodException, SecurityException, | ||
| IllegalAccessException, IllegalArgumentException, InvocationTargetException { | ||
| Method method = TurfMisc.class.getDeclaredMethod("lineIntersects", |
There was a problem hiding this comment.
I'd like to suggest testing against the public API instead of using reflections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
lineIntersectsexcludes line segment endpoints which is not consistent with Turf.js / Turf-Swift.Detail
This and this
ifconditions causes the difference. Turf.js implementation is here.Reference