[sdk] rework event API #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
force-pushed
the
tvn-event-api
branch
2 times, most recently
from
4263239 to
1cea22f
Compare
Chaoba
reviewed
Jan 25, 2021
| MapEvents.STYLE_LOADING_FINISHED -> { | ||
| onStyleLoaded?.let { | ||
| val style = it.onLoad() | ||
| pluginRegistry.onStyleChanged(style) |
There was a problem hiding this comment.
Why don't we have onDidFinishLoadingStyleListeners here? I guess users may request for this event.
| data["render-mode"]!!.contents.toString().toUpperCase(Locale.getDefault()) | ||
| ), | ||
| data["needs-repaint"]!!.contents.toString() == "true", | ||
| data["placement-changed"]!!.contents.toString() == "true" |
There was a problem hiding this comment.
Why need to hard code these properties here?
Closed
4 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<changelog>Rework event API to use untyped core system.</changelog>This PR moves away from the existing typed event API and to the un-typed equivalent. The typed API will be removed upstream shortly. While in beta, we will revisit the event that are emitted.