[location-component] Remove stale state, max/min zoom scale options and puck presets. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pengdev
changed the title
Chaoba
reviewed
Jan 22, 2021
app/src/main/java/com/mapbox/maps/testapp/examples/LocationComponentActivity.kt
Show resolved
Hide resolved
...ent/src/main/java/com/mapbox/maps/plugin/locationcomponent/LocationIndicatorLayerRenderer.kt
Show resolved
Hide resolved
kiryldz
approved these changes
Jan 22, 2021
pengdev
commented
Jan 22, 2021
pengdev
commented
Jan 22, 2021
app/src/main/java/com/mapbox/maps/testapp/examples/LocationComponentActivity.kt
Outdated
Show resolved
Hide resolved
pengdev
force-pushed
the
peng-alignment-with-ios
branch
from
10f75b3 to
8a15bc0
Compare
pengdev
added a commit
that referenced
this pull request
Jan 25, 2021
…nd puck presets. (#19) * Remove stale state, max/min zoom scale options. * Update docs. * Add scale expression support for 2d location puck.
pengdev
added a commit
that referenced
this pull request
Jan 25, 2021
* [location-component] Introduce Location Component Plugin. * [location-component] Improve model scaling using expression. (#7) * [location-component] Fix location provider initialisation order. (#8) * [location-component] Update location component configuration options. (#16) * [location-component] Location component animation (#11) * Introduce animation system * Fixes after rebase * PR fixes * [location-component] Remove stale state, max/min zoom scale options and puck presets. (#19) * Remove stale state, max/min zoom scale options. * Update docs. * Add scale expression support for 2d location puck. * [location-componet] Add more unit tests to increase code coverage. (#10) * [location-componet] Add more unit tests to increase code coverage. * Refactor LocationProviderImpl and add tests. * Remove compass engine. * Rebase to dev. * Add tests for LocationPuckManager. * Use shortest path for bearing animator (#25) * [location-provider] Expose getter for current location provider. (#34) * [location-provider] Expose getter for current location provider. * Bump dependency. * Update doc. * bump dependency. * [location-component] Add readme. * Remove annotation generator validation scriptis. Co-authored-by: Kiryl Dzehtsiarenka <kiryl.dzehtsiarenka@mapbox.com>
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the stale state and max/min zoom scale options.