Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gestures protected animator owners API, make animator owners public #5

Merged
merged 5 commits into from
Jan 20, 2021
Merged

Add gestures protected animator owners API, make animator owners public #5

merged 5 commits into from
Jan 20, 2021

Conversation

kiryldz
Copy link
Contributor

@kiryldz kiryldz commented Jan 18, 2021 •
edited
Loading

<changelog>Add gestures protected animator owners API</changelog>
<changelog>Make animator owners public</changelog>
<changelog>Replace jumpTo with easeTo in gestures</changelog>

@kiryldz kiryldz requested review from LukasPaczos and a team January 18, 2021 16:29
@kiryldz kiryldz self-assigned this Jan 18, 2021
LukasPaczos
LukasPaczos reviewed Jan 18, 2021
View reviewed changes
Copy link

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of nits below. Also, could you add a test that verifies the cancelation behavior?

plugin-animation/src/main/java/com/mapbox/maps/plugin/animation/CameraAnimationsPluginImpl.kt Outdated Show resolved Hide resolved
plugin-animation/src/main/java/com/mapbox/maps/plugin/animation/CameraAnimationsPluginImpl.kt Outdated Show resolved Hide resolved
plugin-gestures/src/main/java/com/mapbox/maps/plugin/gestures/GesturesPluginImpl.kt Outdated Show resolved Hide resolved
plugin-gestures/src/main/java/com/mapbox/maps/plugin/gestures/GesturesPluginImpl.kt Outdated Show resolved Hide resolved
sdk-base/src/main/java/com/mapbox/maps/plugin/gestures/GesturesPlugin.kt Outdated Show resolved Hide resolved
sdk-base/src/main/java/com/mapbox/maps/plugin/gestures/GesturesPlugin.kt Outdated Show resolved Hide resolved
sdk-base/src/main/java/com/mapbox/maps/plugin/animation/CameraAnimationsPlugin.kt Outdated Show resolved Hide resolved
@kiryldz kiryldz requested a review from LukasPaczos January 20, 2021 12:20
Chaoba
Chaoba approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@Chaoba Chaoba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions, others LGTM

plugin-gestures/src/main/java/com/mapbox/maps/plugin/gestures/GesturesPluginImpl.kt Outdated Show resolved Hide resolved
plugin-animation/src/main/java/com/mapbox/maps/plugin/animation/CameraAnimationsPluginImpl.kt Outdated Show resolved Hide resolved
tobrun
tobrun approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would love to see this in action, still a bit hard to wrap my head around how the actual code will look and how execution order/negation is handled.

@kiryldz kiryldz merged commit 26bbc01 into main Jan 20, 2021
@kiryldz kiryldz deleted the kdz-camera-protected-gestures branch January 20, 2021 13:57
@ManolescuSebastian ManolescuSebastian mentioned this pull request Mar 22, 2021
Closed
@RoProducts RoProducts mentioned this pull request Oct 24, 2022
Closed
@scenemax3d scenemax3d mentioned this pull request Jan 28, 2023
Closed
@JDM8 JDM8 mentioned this pull request Jun 19, 2023
Open
@random-abcd random-abcd mentioned this pull request Oct 12, 2023
Open
4 tasks
@maratsct maratsct mentioned this pull request Jun 17, 2024
Closed
@xingzhongyi xingzhongyi mentioned this pull request Dec 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chaoba Chaoba Chaoba approved these changes

@pengdev pengdev pengdev approved these changes

@tobrun tobrun tobrun approved these changes

@LukasPaczos LukasPaczos Awaiting requested review from LukasPaczos

Assignees

@kiryldz kiryldz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kiryldz @tobrun @pengdev @Chaoba @LukasPaczos