Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAVAND-1073: fix alternative routes refresh #6857

Merged
merged 5 commits into from
Jan 20, 2023
Merged

Conversation

dzinad
Copy link
Contributor

@dzinad dzinad commented Jan 20, 2023

Cherry-picks #6848.

@github-actions
Copy link

Changelog

Features

Bug fixes and improvements

  • Increased max distance from the user indicator to route line valid to continue vanishing updates from 3m to 10m. #6854
  • Removed NavigationRoute#hasUnexpectedClosures and added RouteProgress#hasUnexpectedUpcomingClosures instead that checks whether route has upcoming unexpected closures (the algorithm does not take into account closures that the puck has already been on) #6841
  • Fixed an issue where alternative routes might have had an incorrect or incomplete portion of the route refreshed or occasionally fail to refresh. #dd
  • Ensure map-matching considers HOV-only roads as auto accessible. #6834

Known issues ⚠️

Other changes

Android Auto Changelog

Features

Bug fixes and improvements

@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #6857 (71bd99c) into release-v2.10 (3729f69) will increase coverage by 0.02%.
The diff coverage is 87.50%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             release-v2.10    #6857      +/-   ##
===================================================
+ Coverage            72.52%   72.54%   +0.02%     
- Complexity            5546     5557      +11     
===================================================
  Files                  777      779       +2     
  Lines                30062    30120      +58     
  Branches              3544     3553       +9     
===================================================
+ Hits                 21801    21852      +51     
- Misses                6842     6846       +4     
- Partials              1419     1422       +3     
Impacted Files Coverage Δ
...box/navigation/core/NavigationComponentProvider.kt 45.23% <0.00%> (ø)
...e/routealternatives/RouteAlternativesController.kt 75.37% <ø> (ø)
...ore/routerefresh/RouteRefreshControllerProvider.kt 0.00% <0.00%> (ø)
...gation/core/routerefresh/RouteRefreshController.kt 90.90% <64.70%> (-3.02%) ⬇️
...ternatives/AlternativeRouteProgressDataProvider.kt 96.29% <96.29%> (ø)
...ava/com/mapbox/navigation/core/MapboxNavigation.kt 71.10% <100.00%> (+0.04%) ⬆️
...avigation/core/PrimaryRouteProgressDataProvider.kt 100.00% <100.00%> (ø)
...pbox/navigation/core/RoutesProgressDataProvider.kt 100.00% <100.00%> (ø)

@dzinad dzinad merged commit d72b47f into release-v2.10 Jan 20, 2023
@dzinad dzinad deleted the NAVAND-1073-dd-cp branch January 20, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants