Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump NN dependency version to 123.2.0 #6834

Merged
merged 2 commits into from
Jan 13, 2023
Merged

Conversation

Guardiola31337
Copy link
Contributor

Description

  • Bumps NN dependency version to 123.2.0

cc @mapbox/navnative

@Guardiola31337 Guardiola31337 added the Core Work related to core navigation and integrations. label Jan 13, 2023
@Guardiola31337 Guardiola31337 self-assigned this Jan 13, 2023
@github-actions
Copy link

github-actions bot commented Jan 13, 2023

Changelog

Features

  • Introduced ViewStyleCustomization.infoPanelGuidelineMaxPosPercent that allows customization of the NavigationView InfoPanel bottom guideline maximum position. Increased default value to 50%. #6792

Bug fixes and improvements

  • Fixed an issue with NavigationView that caused info panel to shrink in landscape mode with a full screen theme. #6780

  • ⚠️ Updated the NavigationView default navigation puck asset. #6678

    Previous puck can be restored by injecting LocationPuck2D with the bearingImage set to com.mapbox.navigation.ui.maps.R.drawable.mapbox_navigation_puck_icon drawable:

    navigationView.customizeViewStyles {
        locationPuckOptions = LocationPuckOptions.Builder(context)
            .defaultPuck(
                LocationPuck2D(
                    bearingImage = ContextCompat.getDrawable(
                        context,
                        com.mapbox.navigation.ui.maps.R.drawable.mapbox_navigation_puck_icon,
                    )
                )
            )
            .idlePuck(regularPuck(context))
            .build()
    }
  • Fixed an issue where the first voice instruction might have been played twice. #6766

  • Added guarantees that route progress with RouteProgress#currentState == OFF_ROUTE arrives earlier than NavigationRerouteController#reroute is called. #6764

  • Improved MapboxNavigation#startReplayTripSession and ReplayRouteSession so that the previous trip session does not need to be stopped. ⚠️ ReplayRouteSession#onDetached removed the call to stopTripSession. #6817

  • Ensure map-matching considers HOV-only roads as auto accessible. #6834

  • Introduced NavigationViewListener.onSpeedInfoClicked that would be triggered when MapboxSpeedInfoView is clicked upon. #6770

  • Each newly instantiated MapboxRouteArrowView class will initialize the layers with the provided options on the first render call. Previously this would only be done if the layers hadn't already been initialized. #6466

  • Fixed a rare java.lang.NullPointerException: Attempt to read from field 'SpeechAnnouncement PlayCallback.announcement' on a null object reference crash in PlayCallback.getAnnouncement. #6760

  • Fixed standalone MapboxManeuverView appearance when the app also integrates Drop-In UI. #6774

Known issues ⚠️

Other changes

Android Auto Changelog

Features

Bug fixes and improvements

@Guardiola31337 Guardiola31337 added the needs backporting Requires cherry-picking to a currently running release branch label Jan 13, 2023
@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #6834 (a6cc92f) into main (38c986e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #6834   +/-   ##
=========================================
  Coverage     72.63%   72.63%           
  Complexity     5568     5568           
=========================================
  Files           780      780           
  Lines         30104    30104           
  Branches       3556     3556           
=========================================
  Hits          21867    21867           
  Misses         6809     6809           
  Partials       1428     1428           

@Guardiola31337 Guardiola31337 merged commit 95a7221 into main Jan 13, 2023
@Guardiola31337 Guardiola31337 deleted the pg-bump-nn-123.2.0 branch January 13, 2023 15:45
Guardiola31337 added a commit that referenced this pull request Jan 13, 2023
* bump nn dependency version to 123.2.0

* Rename changelog files

Co-authored-by: runner <runner@fv-az588-40>
@github-actions github-actions bot mentioned this pull request Jan 13, 2023
Guardiola31337 added a commit that referenced this pull request Jan 13, 2023
* bump nn dependency version to 123.2.0

* Rename changelog files

Co-authored-by: runner <runner@fv-az588-40>

Co-authored-by: runner <runner@fv-az588-40>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Work related to core navigation and integrations. needs backporting Requires cherry-picking to a currently running release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants