[Drop-In UI] Changes RoadName positioning and customization #6792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…View height and made it customizable via ViewStyleCustomization.infoPanelGuidelineMaxPosPercent.
tomaszrybakiewicz
added
the
UI
Codecov Report
@@ Coverage Diff @@
## main #6792 +/- ##
============================================
- Coverage 72.64% 72.64% -0.01%
- Complexity 5566 5569 +3
============================================
Files 780 780
Lines 30091 30104 +13
Branches 3551 3553 +2
============================================
+ Hits 21860 21869 +9
- Misses 6805 6808 +3
- Partials 1426 1427 +1
|
dzinad
reviewed
Jan 9, 2023
| val maxPos = (parentHeight * GUIDELINE_MAX_POSITION_PERCENT).toInt() | ||
| val pos = parentHeight - infoPanelTop - systemBarsInsets.bottom | ||
| guidelineBottom.setGuidelineEnd(pos.coerceIn(0, maxPos)) | ||
| val maxPos = (parentHeight * maxPosPercent).toInt() - systemBarsInsets.bottom |
There was a problem hiding this comment.
You didn't subtract systemBarsInsets.bottom for maxPos before. Is this behaviour change intentional?
| @@ -81,6 +81,14 @@ internal class InfoPanelCoordinator( | |||
| coroutineScope.launch { | |||
| context.systemBarsInsets.collect { updateGuidelinePosition(systemBarsInsets = it) } | |||
| } | |||
| coroutineScope.launch { | |||
| context.styles.infoPanelGuidelineMaxPosPercent.collect { | |||
There was a problem hiding this comment.
I tried, but unfortunately, Robolectric was throwing exceptions when I tried to layout the view (parentLayout.layout(0, 0, 200, 300)) to get concrete measurements in tests. After fighting with this for over 4 hrs I had to throw the towel.
Zayankovsky
approved these changes
Jan 9, 2023
dzinad
approved these changes
Jan 10, 2023
tomaszrybakiewicz
deleted the
NAVAND-923_tr-drop-in_road_name_label_fix
branch
tomaszrybakiewicz
added a commit
that referenced
this pull request
Jan 10, 2023
* Increased InfoPanel bottom guideline max pos to 50% of the NavigationView height and made it customizable via ViewStyleCustomization.infoPanelGuidelineMaxPosPercent. * CHANGELOG entry * Rename changelog files Co-authored-by: runner <runner@fv-az465-655>
This was referenced Jan 10, 2023
abhishek1508
pushed a commit
that referenced
this pull request
Jan 12, 2023
* Increased InfoPanel bottom guideline max pos to 50% of the NavigationView height and made it customizable via ViewStyleCustomization.infoPanelGuidelineMaxPosPercent. * CHANGELOG entry * Rename changelog files Co-authored-by: runner <runner@fv-az465-655>
This was referenced Jan 12, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes NAVAND-923
Description
InfoPanelbottom guideline max pos to 50% of theNavigationViewheight and made it customizable viaViewStyleCustomization.infoPanelGuidelineMaxPosPercent