Fast integration test for artificial driver #6799

VysotskiVadim · 2023-01-10T10:14:40Z

Added a test which verifies that NN follows location updates generated by "artificial driver" without reroutes.

It works very fast, because it makes NN process location updates as fast as it can, so I can this PR a POC of fast integration tests(https://mapbox.atlassian.net/browse/NN-418). Route Munich-Nuremberg(duration 16240.29) completes in 1 minute on Pixel 6.

github-actions · 2023-01-10T10:32:27Z

Changelog

Features

Introduced ViewStyleCustomization.infoPanelGuidelineMaxPosPercent that allows customization of the NavigationView InfoPanel bottom guideline maximum position. Increased default value to 50%. #6792

Bug fixes and improvements

Fixed an issue with NavigationView that caused info panel to shrink in landscape mode with a full screen theme. #6780

⚠️ Updated the NavigationView default navigation puck asset. #6678

Previous puck can be restored by injecting LocationPuck2D with the bearingImage set to com.mapbox.navigation.ui.maps.R.drawable.mapbox_navigation_puck_icon drawable:

navigationView.customizeViewStyles {
    locationPuckOptions = LocationPuckOptions.Builder(context)
        .defaultPuck(
            LocationPuck2D(
                bearingImage = ContextCompat.getDrawable(
                    context,
                    com.mapbox.navigation.ui.maps.R.drawable.mapbox_navigation_puck_icon,
                )
            )
        )
        .idlePuck(regularPuck(context))
        .build()
}

Fixed an issue where the first voice instruction might have been played twice. #6766
Added guarantees that route progress with RouteProgress#currentState == OFF_ROUTE arrives earlier than NavigationRerouteController#reroute is called. #6764
Introduced NavigationViewListener.onSpeedInfoClicked that would be triggered when MapboxSpeedInfoView is clicked upon. #6770
Each newly instantiated MapboxRouteArrowView class will initialize the layers with the provided options on the first render call. Previously this would only be done if the layers hadn't already been initialized. #6466
Fixed a rare java.lang.NullPointerException: Attempt to read from field 'SpeechAnnouncement PlayCallback.announcement' on a null object reference crash in PlayCallback.getAnnouncement. #6760
Fixed standalone MapboxManeuverView appearance when the app also integrates Drop-In UI. #6774

Known issues ⚠️

Other changes

Android Auto Changelog

Features

Bug fixes and improvements

codecov · 2023-01-10T11:16:37Z

Codecov Report

Merging #6799 (428cd54) into main (61415ea) will increase coverage by 0.00%.
The diff coverage is 94.44%.

@@            Coverage Diff            @@
##               main    #6799   +/-   ##
=========================================
  Coverage     72.64%   72.64%           
+ Complexity     5569     5565    -4     
=========================================
  Files           780      781    +1     
  Lines         30104    30110    +6     
  Branches       3553     3554    +1     
=========================================
+ Hits          21869    21874    +5     
- Misses         6808     6809    +1     
  Partials       1427     1427

Impacted Files	Coverage Δ
...n/core/replay/history/ReplayEventLocationMapper.kt	`93.75% <93.75%> (ø)`
...box/navigation/core/replay/ReplayLocationEngine.kt	`100.00% <100.00%> (ø)`

VysotskiVadim · 2023-01-10T13:51:28Z

...on-core/src/androidTest/java/com/mapbox/navigation/core/trip/service/ArtificialDriverTest.kt

+                for (location in events.map { it.location.mapToLocation() }) {
+                    assertTrue(nativeNavigator.updateLocation(location.toFixLocation()))
+                }


@mapbox/navnative , we have already discussed it, but can you please confirm that this is valid usage of native navigator?
I generated location updates so that they looks like the regular ones, but I pass them to NN faster than they happen in reality keeping the original time, i.e. for the native navigator time goes faster than real time.

Like history recording replay, you can take the locations with proper monotonic time in them and feed back-to-back into the navigator - it will produce the correct result.

VysotskiVadim · 2023-01-10T13:52:59Z

...on-core/src/main/java/com/mapbox/navigation/core/replay/history/ReplayEventLocationMapper.kt

+internal fun ReplayEventLocation.mapToLocation(
+    eventTimeOffset: Double = time ?: 0.0,
+    @VisibleForTesting currentTimeMilliseconds: Long = Date().time,
+    @VisibleForTesting elapsedTimeNano: Long = SystemClock.elapsedRealtimeNanos()
+): Location {


@kmadsen , I didn't understand which problems mapboxReplayer.eventRealtimeOffset solves, so maybe it isn't the best API for the mapper. Any suggestions?

dzinad · 2023-01-10T13:53:10Z

...on-core/src/androidTest/java/com/mapbox/navigation/core/trip/service/ArtificialDriverTest.kt

+            .build()
+    )
+    block(mapboxNavigation, MapboxNativeNavigatorImpl)
+    mapboxNavigation.onDestroy()


onDestroyed won't be called if the test fails, you should use a rule for that.

thanks. I think try-finaly will work too, won't they? 250aa56

It will, yes.

dzinad · 2023-01-10T13:58:11Z

...on-core/src/androidTest/java/com/mapbox/navigation/core/trip/service/ArtificialDriverTest.kt

+
+                val states = statusesTracking.await()
+                val historyFile = suspendCoroutine<String> { continuation ->
+                    mapboxNavigation.historyRecorder.stopRecording {


There is a suspend version of this method:

val historyFile = mapboxNavigation.historyRecorder.startRecording()

Can you please help me find it? I don't see suspend version here

You probably meant this one, but artificial driver test is in a different module as it accesses internal APIs

Yes, this one. Oh, it's a different module. OK then.

dzinad · 2023-01-10T13:59:38Z

...on-core/src/androidTest/java/com/mapbox/navigation/core/trip/service/ArtificialDriverTest.kt

+                        continuation.resume(it ?: "null")
+                    }
+                }
+                val notTrackingStates = states.filter { it.routeState != RouteState.TRACKING }


Is this the right check? I mean do we want to test that we only have tracking or that we don't have off_route? What about INITIALIZED state for example?

what do you think the right check should be?

I wrote this test to verify absence of reroutes when location updates are simulated by our artificial driver. That's why I check only tracking part. But I'm open to suggestions, if you think a different check will bring us more benefits, I'm happy to change the current one 🙂

Oops, I thought I left a comment but I didn't. Judging by the name of the test, I'd do sth like:

val offRouteStates = states.filter { it.routeState == RouteState.OFF_ROUTE }

Good idea! applied

dzinad · 2023-01-16T09:22:47Z

...on-core/src/androidTest/java/com/mapbox/navigation/core/trip/service/ArtificialDriverTest.kt

+            "&language=en" +
+            "&overview=full" +
+            "&steps=true" +
+            "&access_token=YOUR_MAPBOX_ACCESS_TOKEN",


See NativeNavigatorCallbackOrderTest, it already uses access token that is being injected on CI.

Ah, you don't want it to be present in the URL.

VysotskiVadim force-pushed the vv-test-integration-of-artificial-driver-and-nn branch from 220d55a to 1ea6c0a Compare January 10, 2023 10:31

VysotskiVadim added the skip changelog Should not be added into version changelog. label Jan 10, 2023

VysotskiVadim requested a review from kmadsen January 10, 2023 13:48

VysotskiVadim commented Jan 10, 2023

View reviewed changes

VysotskiVadim changed the title ~~Fast integration test for artificial driver [work in progress]~~ Fast integration test for artificial driver Jan 10, 2023

VysotskiVadim requested review from dzinad, RingerJK and LukasPaczos January 10, 2023 13:53

VysotskiVadim marked this pull request as ready for review January 10, 2023 13:54

dzinad reviewed Jan 10, 2023

View reviewed changes

VysotskiVadim added 7 commits January 11, 2023 10:36

at least it works

4a306fa

refactoring

c87ab6f

fixed geomertries

ce46fff

moved mapper away

269f7b5

fixed lint errors

8e12f4a

ignore results of the test until NN fixes the issue

6701931

always destroy navigator

d9471d9

VysotskiVadim force-pushed the vv-test-integration-of-artificial-driver-and-nn branch from 250aa56 to d9471d9 Compare January 11, 2023 09:37

VysotskiVadim requested a review from dzinad January 11, 2023 09:39

updated checks so that only off-route events are detected

428cd54

VysotskiVadim force-pushed the vv-test-integration-of-artificial-driver-and-nn branch from 261c1f7 to 428cd54 Compare January 13, 2023 10:25

dzinad reviewed Jan 16, 2023

View reviewed changes

dzinad approved these changes Jan 16, 2023

View reviewed changes

VysotskiVadim merged commit 6fc4e70 into main Jan 16, 2023

VysotskiVadim deleted the vv-test-integration-of-artificial-driver-and-nn branch January 16, 2023 09:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fast integration test for artificial driver #6799

Fast integration test for artificial driver #6799

VysotskiVadim commented Jan 10, 2023 •

edited

Loading

github-actions bot commented Jan 10, 2023 •

edited

Loading

Features

Bug fixes and improvements

Known issues ⚠️

Other changes

Features

Bug fixes and improvements

codecov bot commented Jan 10, 2023 •

edited

Loading

VysotskiVadim Jan 10, 2023

mskurydin Jan 10, 2023

VysotskiVadim Jan 10, 2023

dzinad Jan 10, 2023

VysotskiVadim Jan 11, 2023

dzinad Jan 12, 2023 •

edited

Loading

dzinad Jan 10, 2023

VysotskiVadim Jan 11, 2023

VysotskiVadim Jan 11, 2023 •

edited

Loading

dzinad Jan 12, 2023

dzinad Jan 10, 2023

VysotskiVadim Jan 10, 2023

VysotskiVadim Jan 11, 2023

dzinad Jan 12, 2023

VysotskiVadim Jan 13, 2023

dzinad Jan 16, 2023

dzinad Jan 16, 2023

Fast integration test for artificial driver #6799

Fast integration test for artificial driver #6799

Conversation

VysotskiVadim commented Jan 10, 2023 • edited Loading

github-actions bot commented Jan 10, 2023 • edited Loading

Features

Bug fixes and improvements

Known issues ⚠️

Other changes

Features

Bug fixes and improvements

codecov bot commented Jan 10, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dzinad Jan 12, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VysotskiVadim Jan 11, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VysotskiVadim commented Jan 10, 2023 •

edited

Loading

github-actions bot commented Jan 10, 2023 •

edited

Loading

codecov bot commented Jan 10, 2023 •

edited

Loading

dzinad Jan 12, 2023 •

edited

Loading

VysotskiVadim Jan 11, 2023 •

edited

Loading