Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix info panel dimensions in landscape with a full screen theme #6780

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

Zayankovsky
Copy link
Contributor

Description

Noticed that in landscape mode when a full screen theme is used, info panel became smaller than expected (it should have the same width as maneuver view). The issue was caused by applying window insets to a wrong view.

Screenshots or Gifs

Before After
before_1 after_1
before_2 after_2

@Zayankovsky Zayankovsky added bug Defect to be fixed. UI Work related to visual components, Android Auto, Camera, 3D, voice, etc. labels Jan 4, 2023
@Zayankovsky Zayankovsky self-assigned this Jan 4, 2023
@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Merging #6780 (5943a14) into main (b329337) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #6780      +/-   ##
============================================
- Coverage     72.51%   72.50%   -0.01%     
+ Complexity     5551     5550       -1     
============================================
  Files           779      779              
  Lines         30072    30067       -5     
  Branches       3548     3548              
============================================
- Hits          21806    21801       -5     
  Misses         6841     6841              
  Partials       1425     1425              
Impacted Files Coverage Δ
.../navigation/dropin/infopanel/InfoPanelComponent.kt 90.90% <100.00%> (-1.69%) ⬇️

Copy link
Contributor

@tomaszrybakiewicz tomaszrybakiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defect to be fixed. UI Work related to visual components, Android Auto, Camera, 3D, voice, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants