-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Copilot unrecognized
fields serialization
#6821
Fix Copilot unrecognized
fields serialization
#6821
Conversation
ChangelogFeatures
Bug fixes and improvements
Known issues
|
.registerTypeAdapterFactory(DirectionsAdapterFactory.create()) | ||
.registerTypeAdapter(Point::class.java, PointAsCoordinatesTypeAdapter()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be nice if mapbox-java exposed a single point for adapter, so that:
- other users could use it in their projects with 1 extra line of code
- if we add new adapters, we don't need to add them to copilot too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea! Could you cut a ticket in mapbox-java
when you have a chance? 🙏
Codecov Report
@@ Coverage Diff @@
## main #6821 +/- ##
=========================================
Coverage 72.63% 72.63%
Complexity 5568 5568
=========================================
Files 780 780
Lines 30101 30104 +3
Branches 3556 3556
=========================================
+ Hits 21864 21867 +3
Misses 6809 6809
Partials 1428 1428
|
Description
While testing we found that
DirectionsResponse
fields from Copilot History files were not properly serialized:unrecognized
fields not serialized (also obfuscated if Proguard was enabled)E.g. 👀
This PR fixes it 👀