Add example for new location layer functionality #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximAlien
reviewed
Jun 17, 2021
|
This is not related to this example, but can you check why 3D puck is rendered below maneuver arrow?
|
|
@MaximAlien |
|
The puck layer position issue has been fixed in mapbox/mapbox-navigation-ios#3106 |
1ec5
reviewed
Jun 29, 2021
ShanMa1991
force-pushed
the
shan/userLocationStyle-example-115
branch
from
130e130
to
6d69dfd
Compare
ShanMa1991
force-pushed
the
shan/userLocationStyle-example-115
branch
from
7b77383
to
07f1aa4
Compare
1ec5
approved these changes
Jul 1, 2021
|
|
||
| func setupPuck3D() { | ||
| // It's required to provide a `Puck3DConfiguration` to the `UserLocationStyle.puck3D`, a `gltf` 3D asset will be used as the `Model` source. | ||
| // The model source is from NASA's curiosity(clean) in https://github.com/nasa/NASA-3D-Resources/blob/master/3D%20Models/Curiosity%20(Clean)/MSL_clean.blend |
There was a problem hiding this comment.
Let’s link to the permalink just in case the file gets renamed or moved in the future:
Suggested change
| // The model source is from NASA's curiosity(clean) in https://github.com/nasa/NASA-3D-Resources/blob/master/3D%20Models/Curiosity%20(Clean)/MSL_clean.blend | |
| // NASA's Curiosity rover from https://github.com/nasa/NASA-3D-Resources/blob/463f2b2941e3e95acfcbb12f783070e9d92ee267/3D%20Models/Curiosity%20(Clean)/MSL_clean.blend |
There was a problem hiding this comment.
Thanks for the suggestion. I added a gif example of the Curiosity in SF ☝️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is to fix #115 to create example for new location layer functionality. It would allow the developers to provide custom user location style for navigation, including the default
userCourseView, and thepuck2D,puck3D.Example of using the Curiosity 3D model as below: