Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to set locale for top and bottom banner views #4595

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Conversation

kried
Copy link
Contributor

@kried kried commented Feb 13, 2024

Description

Closes #4581
https://mapbox.atlassian.net/browse/NAVIOS-1547

Implementation

Makes properties public

Usage example
let top = TopBannerViewController()
top.instructionsBannerView.distanceFormatter.locale = .init(identifier: "zh-Hans")
navigationOptions.topBanner = top

let bottom = BottomBannerViewController()
bottom.distanceFormatter.locale = .init(identifier: "zh-Hans")
bottom.dateFormatter.locale = .init(identifier: "zh-Hans")
navigationOptions.bottomBanner = bottom

let navigationViewController = NavigationViewController(for: indexedRouteResponse, navigationOptions: navigationOptions)
bottom.delegate = navigationViewController
top.delegate = navigationViewController

@kried kried self-assigned this Feb 13, 2024
@kried kried requested a review from a team as a code owner February 13, 2024 10:47
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fb0a314) 60.62% compared to head (86a2748) 60.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4595      +/-   ##
==========================================
- Coverage   60.62%   60.30%   -0.32%     
==========================================
  Files         189      189              
  Lines       21265    21058     -207     
==========================================
- Hits        12892    12700     -192     
+ Misses       8373     8358      -15     
Files Coverage Δ
.../MapboxNavigation/BottomBannerViewController.swift 72.72% <100.00%> (-0.49%) ⬇️
...rces/MapboxNavigation/InstructionsBannerView.swift 80.73% <100.00%> (-0.13%) ⬇️
...ces/MapboxNavigation/TopBannerViewController.swift 24.28% <100.00%> (-1.36%) ⬇️

... and 63 files with indirect coverage changes

@kried kried merged commit c09a4b8 into main Feb 16, 2024
21 checks passed
@kried kried deleted the NAVIOS-1547 branch February 16, 2024 13:07
azarovalex added a commit that referenced this pull request Apr 15, 2024
* Use camera options to calculate zoom for overview camera (#4593)

* Use camera options to calculate zoom for overview camera

* Create dependabot.yml

Enable Dependabot version updates

* Bump actions/checkout from 3 to 4

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump github/codeql-action from 2 to 3

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2 to 3.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@v2...v3)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fixed the possible situation when the upcoming route leg is rendered above the active route leg (#4589)

* Add the ability to set locale for top and bottom banner views (#4595)

* Implement configurable waypoints in CarPlayDelegate

* Update Tests/MapboxNavigationTests/CarPlayUtils.swift

Co-authored-by: Nastassia Makaranka <nastassia.makaranka@mapbox.com>

* Update CHANGELOG.md

Co-authored-by: Nastassia Makaranka <nastassia.makaranka@mapbox.com>

* Update dependencies (#4614)

* vk/dependencies-update: bumped Directions to 2.12.0, Maps to 10.16.5. Now compatible with Turf 2.7.0.

* vk/dependencies-update: CHANGELOG updated

* vk/dependencies-update: bumped NN to v202; update cocoapods in gemfile to 1.14

* vk/dependencies-update: unit tests fix

* Sync Package.resolved with last resolved dependencies

* Update CHANGELOG.md

* Sync CocoaPodsTest

---------

Co-authored-by: Udumft <viktor.kononov@mapbox.com>

* Fix SystemSpeechSynthesizer related main thread hang on NavigationViewController creation (#4617)

* Don't check if AVSpeechSynthesizer.isSpeaking when unmuting it

* add changelog entry

* Improve error handing in case of invalid route responses (#4618)

* Improve error handing in case of invalid route responses

* Fix the order in which delegate is notified about failed reroute attempt

* Fix for old Swift compiler versions

* Fixed project structure in Carthage integration

* Added changelog entry

* Fix Examples signing when building on a real device (#4619)

* Fix Examples signing when building on a real device

* Replace build phases with the new script in 3 test targets

* Grant exec permissions to the script

* Fix carplay background maneuver card

* Fix method annotation and desctiption

* Update changelog

* Fix compile errors

* Update breaking changes list

* Update changelog

* Update spelling

* Fix spelling

* Update CHANGELOG.md

* Update NN and Maps (#4628)

* Update NN and Maps

* Update CHANGELOG.md

* Update CHANGELOG.md

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Nastassia Makaranka <nastassia.makaranka@mapbox.com>
Co-authored-by: Thibaud Lopez Schneider <ThibaudLopez@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Max <max.chizhavko@mapbox.com>
Co-authored-by: Max <70526783+chizhavko@users.noreply.github.com>
Co-authored-by: Udumft <viktor.kononov@mapbox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: change localized to Chinese, all the naivgationView's text have changed except unit text
2 participants