Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry pick] Add the ability to set locale for top and bottom banner views #4602

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

kried
Copy link
Contributor

@kried kried commented Feb 16, 2024

Description

Cherry pick of #4595 into 2.18

@kried kried self-assigned this Feb 16, 2024
@kried kried requested a review from a team as a code owner February 16, 2024 13:10
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f02db2) 60.58% compared to head (090b7f8) 60.59%.
Report is 1 commits behind head on release-v2.18.

Impacted file tree graph

@@              Coverage Diff               @@
##           release-v2.18    #4602   +/-   ##
==============================================
  Coverage          60.58%   60.59%           
==============================================
  Files                189      189           
  Lines              21249    21249           
==============================================
+ Hits               12874    12876    +2     
+ Misses              8375     8373    -2     
Files Coverage Δ
.../MapboxNavigation/BottomBannerViewController.swift 73.21% <100.00%> (ø)
...rces/MapboxNavigation/InstructionsBannerView.swift 80.85% <100.00%> (ø)
...ces/MapboxNavigation/TopBannerViewController.swift 25.64% <100.00%> (ø)

... and 1 file with indirect coverage changes

@kried kried merged commit b91e86e into release-v2.18 Feb 16, 2024
18 checks passed
@kried kried deleted the cherry-pick-pr-4595 branch February 16, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants